From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
linux-kernel@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [PATCH] serial: serial_txx9 driver update
Date: Sun, 22 Jan 2006 08:00:15 +0000 [thread overview]
Message-ID: <20060122080015.GA10398@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060121233649.51211403.akpm@osdl.org>
On Sat, Jan 21, 2006 at 11:36:49PM -0800, Andrew Morton wrote:
> Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> >
> > serial_txx9_verify_port(struct uart_port *port, struct serial_struct *ser)
> > {
> > - if (ser->irq < 0 ||
> > - ser->baud_base < 9600 || ser->type != PORT_TXX9)
> > + unsigned long new_port = (unsigned long)ser->port +
> > + ((unsigned long)ser->port_high << ((sizeof(long) - sizeof(int)) * 8));
>
> Are you sure about this part? Shifting something left by sizeof(something)
> seems very strange. It'll give different results on 64-bit machines for
> the same hardware. Are you sure it wasn't supposed to be an addition?
There is a definition for that constant - it's called HIGH_BITS_OFFSET.
No need to try to buggily recreate it.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-01-22 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 17:19 Atsushi Nemoto
2006-01-22 7:36 ` Andrew Morton
2006-01-22 8:00 ` Russell King [this message]
2006-01-22 8:33 ` Andrew Morton
2006-01-22 23:02 ` Russell King
2006-01-23 6:05 ` Atsushi Nemoto
2006-01-23 9:57 ` Russell King
2006-01-23 13:39 ` Atsushi Nemoto
2006-01-23 13:42 ` Atsushi Nemoto
2006-01-23 19:49 ` Russell King
2006-01-24 2:24 ` Atsushi Nemoto
2006-12-21 17:01 Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060122080015.GA10398@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome