From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Fernando Luis Vazquez Cao <fernando@intellilink.co.jp>,
ebiederm@xmission.com, vgoyal@in.ibm.com,
linux-kernel@vger.kernel.org, fastboot@lists.osdl.org
Subject: Re: [PATCH 3/5] stack overflow safe kdump (2.6.16-rc1-i386) - fault
Date: Wed, 25 Jan 2006 08:56:44 +0100 [thread overview]
Message-ID: <200601250856.44687.ak@suse.de> (raw)
In-Reply-To: <20060124231510.35eabe15.akpm@osdl.org>
On Wednesday 25 January 2006 08:15, Andrew Morton wrote:
> Fernando Luis Vazquez Cao <fernando@intellilink.co.jp> wrote:
> > When we have a bloated stack it is likely that it ends up making an
> > invalid memory access that in turn causes a page fault. Take this case
> > into account in the page fault code.
> >
> > + if (!virt_addr_valid(tsk)) {
>
> Is virt_addr_valid() a sufficiently strong test here? One could probe the
> address to see if it generates a fault, like the __get_user() in
> kmem_cache_create().
Recursive page faults are always risky because if things go bad they
can lead to unbounded recursion. I think the scheduler knows anyways
which process currently executes on a CPU so it might be better to get
the information from there.
-Andi
next prev parent reply other threads:[~2006-01-25 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 6:53 Fernando Luis Vazquez Cao
2006-01-25 7:15 ` Andrew Morton
2006-01-25 7:56 ` Andi Kleen [this message]
2006-01-25 8:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601250856.44687.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=fernando@intellilink.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®