mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: ebiederm@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exec: Only allow a threaded init to exec from the thread_group_leader
Date: Sun, 29 Jan 2006 11:32:12 -0800	[thread overview]
Message-ID: <20060129113212.5b4a50ed.akpm@osdl.org> (raw)
In-Reply-To: <20060129152451.GD1764@elf.ucw.cz>

Pavel Machek <pavel@ucw.cz> wrote:
>
> On Ne 29-01-06 02:48:31, Andrew Morton wrote:
> > ebiederm@xmission.com (Eric W. Biederman) wrote:
> > >
> > >  If process id namespaces become a reality init stops being
> > >  terribly special, and becomes something you may have several
> > >  of running at any one time.  If one of those inits is compromised
> > >  by a hostile user I having the whole system go down so we can
> > >  avoid executing a cheap test sounds terribly wrong.  That is
> > >  why I really care.
> > 
> > Wouldn't it be better to do nothing until/unless there's some code in the
> > kernel or init which actually needs the change?
> 
> It is common to do init=/bin/bash, and I guess people are doing it
> with all kinds of wonderful apps....

err, good point.  And no reports of peculiar things happening with
threading.  Eric's check has the (slight) potential to cause some things to
stop working though.

  reply	other threads:[~2006-01-29 19:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-29  6:18 Eric W. Biederman
2006-01-29  8:36 ` Andrew Morton
2006-01-29 10:25   ` Eric W. Biederman
2006-01-29 10:48     ` Andrew Morton
2006-01-29 15:24       ` Pavel Machek
2006-01-29 19:32         ` Andrew Morton [this message]
2006-01-29 21:32         ` Eric W. Biederman
2006-01-30  9:15     ` Jan Engelhardt
2006-01-30 20:41       ` Eric W. Biederman
     [not found] <5AeeD-7xb-7@gated-at.bofh.it>
     [not found] ` <5Aggm-1V6-3@gated-at.bofh.it>
     [not found]   ` <5AhYT-4uR-7@gated-at.bofh.it>
2006-01-29 13:36     ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060129113212.5b4a50ed.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®