From: Andrew Morton <akpm@osdl.org>
To: Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp>
Cc: ananth@in.ibm.com, prasanna@in.ibm.com,
anil.s.keshavamurthy@intel.com, hiramatu@sdl.hitachi.co.jp,
systemtap@sources.redhat.com, jkenisto@us.ibm.com,
linux-kernel@vger.kernel.org, sugita@sdl.hitachi.co.jp,
soshima@redhat.com, haoki@redhat.com
Subject: Re: [PATCH] kretprobe: kretprobe-booster against 2.6.16-rc1 for i386
Date: Tue, 31 Jan 2006 14:55:40 -0800 [thread overview]
Message-ID: <20060131145540.3e9a78be.akpm@osdl.org> (raw)
In-Reply-To: <43DEC13E.8020200@sdl.hitachi.co.jp>
Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp> wrote:
>
> - regs->eip = orig_ret_address;
>
> - reset_current_kprobe();
> spin_unlock_irqrestore(&kretprobe_lock, flags);
> - preempt_enable_no_resched();
Again, the patch removes a preempt_enable() and doesn't add a
preempt_disable(). Maybe this is to balance the earlier patch. If so,
they should both be in the same patch so the kernel works OK at each stage.
You didn't include a description of what this patch actually does.
After all the corrections I'm not terribly confident that the three patches
which I ended up with are correct. Please check them carefully.
next prev parent reply other threads:[~2006-01-31 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 12:45 Masami Hiramatsu
2006-01-31 1:45 ` Masami Hiramatsu
2006-01-31 22:55 ` Andrew Morton [this message]
2006-02-01 13:02 ` Masami Hiramatsu
2006-02-13 12:12 ` [PATCH][take 2] kretprobe: kretprobe-booster against 2.6.16-rc2 " Masami Hiramatsu
2006-02-13 23:34 ` Andrew Morton
2006-02-07 23:49 [PATCH] kretprobe: kretprobe-booster against 2.6.16-rc1 " Chuck Ebbert
2006-02-08 7:25 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060131145540.3e9a78be.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=haoki@redhat.com \
--cc=hiramatu@sdl.hitachi.co.jp \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=soshima@redhat.com \
--cc=sugita@sdl.hitachi.co.jp \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®