mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	USB development list <linux-usb-devel@lists.sourceforge.net>
Subject: Re: [PATCH] usbcore: fix compile error with CONFIG_USB_SUSPEND=n
Date: Wed, 1 Feb 2006 08:01:48 -0800	[thread overview]
Message-ID: <200602010801.48348.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0602011044270.5635-100000@iolanthe.rowland.org>

On Wednesday 01 February 2006 7:47 am, Alan Stern wrote:

> This should fix it.

Well, a warning which in this case actually does indicate an
error ... but yes, this looks right.  Thanks.

- Dave

 
> Index: usb-2.6/drivers/usb/core/hub.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/core/hub.c
> +++ usb-2.6/drivers/usb/core/hub.c
> @@ -1890,8 +1890,8 @@ int usb_resume_device(struct usb_device 
>  			status = hub_port_resume(hdev_to_hub(udev->parent),
>  					udev->portnum, udev);
>  		} else
> -			status = 0;
>  #endif
> +			status = 0;
>  	} else
>  		status = finish_device_resume(udev);
>  	if (status < 0)
> 

      reply	other threads:[~2006-02-01 16:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060131214432.566abcff.akpm@osdl.org>
2006-02-01 15:47 ` Alan Stern
2006-02-01 16:01   ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200602010801.48348.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome