From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Purpose of MMC_DATA_MULTI?
Date: Thu, 2 Feb 2006 09:59:10 +0000 [thread overview]
Message-ID: <20060202095910.GB5034@flint.arm.linux.org.uk> (raw)
In-Reply-To: <43E1D5BF.5000807@drzeus.cx>
On Thu, Feb 02, 2006 at 10:49:51AM +0100, Pierre Ossman wrote:
> Russell King wrote:
> >In short, it's defined to be whatever AT91_MCI_TRTYP_MULTIPLE means in
> >the AT91RM9200 MMC host driver, which appears to be set for any of the
> >multiple block commands. They currently are doing:
>
> That's a bit fuzzy and bound to give problems. Why not settle for the
> first case and change their code to check the block count in the
> request?
Mainly because I don't know if that's sufficient, and until I get around
to finding and reading the AT91RM9200 data sheet, I won't know if it is.
What I do know is that the addition of that flag provides the exact
information which the driver wants.
> >and using that as a lookup table by command for the value to put into
> >the command register. I want to eliminate that, and not passing the
> >MULTI flag prevents elimination of this table.
>
> Seems to be a common theme in the more recent drivers. Don't they teach
> people proper layering in the schools anymore? :)
>From the evidence to date, it would appear not.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-02-02 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 6:40 Pierre Ossman
2006-02-01 9:29 ` Russell King
2006-02-01 9:37 ` Pierre Ossman
2006-02-02 9:36 ` Russell King
2006-02-02 9:49 ` Pierre Ossman
2006-02-02 9:59 ` Russell King [this message]
2006-02-02 15:00 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060202095910.GB5034@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome