From: Andrew Morton <akpm@osdl.org>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: ashok.raj@intel.com, davej@redhat.com,
linux-kernel@vger.kernel.org, pavel@ucw.cz
Subject: Re: [patch -mm4] i386 cpu hotplug: don't access freed memory
Date: Thu, 2 Feb 2006 16:52:57 -0800 [thread overview]
Message-ID: <20060202165257.29dcfa20.akpm@osdl.org> (raw)
In-Reply-To: <200602021904_MC3-1-B771-46F7@compuserve.com>
Chuck Ebbert <76306.1226@compuserve.com> wrote:
>
> @@ -160,10 +162,17 @@ static void __cpuinit get_cpu_vendor(str
> c->x86_vendor = i;
> if (!early)
> this_cpu = cpu_devs[i];
> - break;
> + return;
> }
> }
> }
> + if (!printed) {
> + printed++;
> + printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n");
> + printk(KERN_ERR "CPU: Your system may be unstable.\n");
> + }
> + c->x86_vendor = X86_VENDOR_UNKNOWN;
> + this_cpu = &default_cpu;
Well that's a worry. Under what circumstances (if any) will this final bit
of code get executed?
next prev parent reply other threads:[~2006-02-03 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-03 0:00 Chuck Ebbert
2006-02-03 0:52 ` Andrew Morton [this message]
2006-02-03 1:33 ` Dave Jones
2006-02-03 7:02 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060202165257.29dcfa20.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=76306.1226@compuserve.com \
--cc=ashok.raj@intel.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome