mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-rc1-mm5
Date: Sat, 4 Feb 2006 01:36:13 -0800	[thread overview]
Message-ID: <20060204013613.0567ff5a.akpm@osdl.org> (raw)
In-Reply-To: <20060204092941.GB9275@mars.ravnborg.org>

Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>  > 
>  > Known problems:
>  > 
>  > - Sam has added a new check in the kbuild tree.  It detects multiple
>  >   instances of EXPORT_SYMBOL(foo) across separate .o files.
>  > 
>  >   It catches a _lot_ of problems.   You'll see something like this:
> 
>  Sigh. I did a 'make allmodconfig' on x86_64 and found to my suprise only
>  a sinlge symbol being exported more than one time.
> 
>  This is purely a consistency check introduced by commit:
>  http://www.kernel.org/git/?p=linux/kernel/git/sam/kbuild.git;a=commit;h=cd1f125e5808203d3bf58f1d04a9cbd33f60fdb6

There were several tens on powerpc, sparc64, etc.

>  I can rip it out again if the noise/value ratio is too high.

No, let's keep it.  We're wasting memory on this stuff.

> We should IMO try to keep the exports in generic code.

Yes, I guess so.  It gets tricky when you get onto things like the string
functions, most of which may be impemented in generic code or may be in
arch code, depending on __ARCH_HAVE_stuff.

  reply	other threads:[~2006-02-04  9:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-03  8:07 2.6.16-rc1-mm5 Andrew Morton
2006-02-03 10:17 ` 2.6.16-rc1-mm5 Benoit Boissinot
2006-02-03 20:13   ` 2.6.16-rc1-mm5 Benoit Boissinot
2006-02-03 20:36     ` 2.6.16-rc1-mm5 Andrew Morton
2006-02-03 11:51 ` [-mm patch] Makefile: remove a tab from an empty line Adrian Bunk
2006-02-03 20:57 ` [-mm patch] kernel/time/timeofday.c: make struct ts_interval static Adrian Bunk
2006-02-03 21:50   ` john stultz
2006-02-03 20:59 ` [-mm patch] kernel/timer.c: make some variables static Adrian Bunk
2006-02-03 21:02 ` [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again Adrian Bunk
2006-02-04 23:51   ` David S. Miller
2006-02-03 21:09 ` [-mm patch] make some "struct clocksource" static Adrian Bunk
2006-02-03 21:12 ` [-mm patch] arch/i386/kernel/cpu/: make tons of functions static Adrian Bunk
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
2006-02-04  2:43   ` Jody McIntyre
2006-02-04  9:20     ` Sam Ravnborg
2006-02-04  9:08   ` Stefan Richter
2006-02-04  9:30     ` Stefan Richter
2006-02-04  9:31     ` Johannes Berg
2006-02-04  9:58       ` Stefan Richter
2006-02-06  4:31   ` Jody McIntyre
2006-02-04  7:59 ` 2.6.16-rc1-mm5 Matthias Urlichs
2006-02-04  9:29 ` 2.6.16-rc1-mm5 Sam Ravnborg
2006-02-04  9:36   ` Andrew Morton [this message]
     [not found] <20060203000704.3964a39f.akpm__33726.4416892596$1138954098$gmane$org@osdl.org>
2006-02-08  6:20 ` 2.6.16-rc1-mm5 Reuben Farrelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060204013613.0567ff5a.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome