From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932184AbWBFVdM (ORCPT ); Mon, 6 Feb 2006 16:33:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932185AbWBFVdM (ORCPT ); Mon, 6 Feb 2006 16:33:12 -0500 Received: from mx1.redhat.com ([66.187.233.31]:9658 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932184AbWBFVdL (ORCPT ); Mon, 6 Feb 2006 16:33:11 -0500 Date: Mon, 6 Feb 2006 13:32:34 -0800 From: Pete Zaitcev To: Hugh Dickins Cc: khali@linux-fr.org, 76306.1226@compuserv.com, akpm@osdl.org, linux-kernel@vger.kernel.org, zaitcev@redhat.com Subject: Re: [PATCH] stop ==== emergency Message-Id: <20060206133234.1ca5d1ed.zaitcev@redhat.com> In-Reply-To: References: <20060205205709.0b88171b.zaitcev@redhat.com> <20060206195504.16b60b93.khali@linux-fr.org> Organization: Red Hat, Inc. X-Mailer: Sylpheed version 2.0.4 (GTK+ 2.8.9; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Feb 2006 21:11:11 +0000 (GMT), Hugh Dickins wrote: > But my own interest in minimizing printk calls is rather low at the > moment; and they're hardly time-critical, are they? Absolutely, saving time by mering printks is rather stupid. That said, I'm totally sick of "<4>" all over the place. You might not see it on your VGA, but it leakes everywhere else and is annoying. As far as I am concerned, every printk must end with a newline and this is why I disagreed with your printk(log_lvl); -- Pete