mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] updated fstatat64 support
Date: Sat, 11 Feb 2006 12:21:57 +0100	[thread overview]
Message-ID: <20060211112157.GA9371@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <200602101528.k1AFSFIg011658@devserv.devel.redhat.com>

> --- linux-2.6.15.i686/arch/i386/kernel/syscall_table.S-at	2006-02-06 13:11:24.000000000 -0800
> +++ linux-2.6.15.i686/arch/i386/kernel/syscall_table.S	2006-02-06 13:11:34.000000000 -0800
> @@ -299,7 +299,7 @@
>  	.long sys_mknodat
>  	.long sys_fchownat
>  	.long sys_futimesat
> -	.long sys_newfstatat		/* 300 */
> +	.long sys_fstatat64		/* 300 */
>  	.long sys_unlinkat
>  	.long sys_renameat
>  	.long sys_linkat
> --- linux-2.6.15.i686/arch/x86_64/ia32/ia32entry.S-at	2006-02-06 13:05:04.000000000 -0800
> +++ linux-2.6.15.i686/arch/x86_64/ia32/ia32entry.S	2006-02-06 13:05:21.000000000 -0800
> @@ -677,7 +677,7 @@
>  	.quad sys_mknodat
>  	.quad sys_fchownat
>  	.quad compat_sys_futimesat
> -	.quad compat_sys_newfstatat	/* 300 */
> +	.quad sys32_fstatat		/* 300 */
>  	.quad sys_unlinkat
>  	.quad sys_renameat
>  	.quad sys_linkat

So we end up with sys_newfstatat for 64 bit architectures, sys_fstatat64
for 32 bit architectures and sys32_fstatat for compat mode. Shouldn't the
name of the compat call changed to sys32_fstatat64?
At least that is how it used to be for all other *64 compat system calls
like e.g. fstat64.

Heiko

  reply	other threads:[~2006-02-11 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-10 15:28 Ulrich Drepper
2006-02-11 11:21 ` Heiko Carstens [this message]
2006-02-12 13:09   ` Olaf Hering
2006-02-12 16:38     ` Ulrich Drepper
2006-02-12 16:48       ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060211112157.GA9371@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome