From: Jesper Juhl <jesper.juhl@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Marc Boucher <marc@mbsi.ca>, James Morris <jmorris@namei.org>,
Harald Welte <laforge@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Jesper Juhl <jesper.juhl@gmail.com>,
coreteam@netfilter.org, netfilter@lists.netfilter.org,
netfilter-devel@lists.netfilter.org
Subject: [PATCH] netfilter: fix build error due to missing has_bridge_parent macro
Date: Sun, 12 Feb 2006 03:20:36 +0100 [thread overview]
Message-ID: <200602120320.37042.jesper.juhl@gmail.com> (raw)
Hi,
I just did an allyesconfig test build of 2.6.16-rc2-git10 and found a build
problem.
commit 5dce971acf2ae20c80d5e9d1f6bbf17376870911 removed the
"has_bridge_parent" macro from net/bridge/br_netfilter.c, resulting in the
following warning at compile time:
net/bridge/br_netfilter.c: In function `br_nf_post_routing':
net/bridge/br_netfilter.c:808: warning: implicit declaration of function `has_bridge_parent'
and this error at link time:
net/built-in.o(.text+0xeae28): In function `br_nf_post_routing':
net/bridge/br_netfilter.c:808: undefined reference to `has_bridge_parent'
make: *** [.tmp_vmlinux1] Error 1
The patch below fixes the problem.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
Patch is compile tested only but should be obviously correct.
net/bridge/br_netfilter.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.16-rc2-git10/net/bridge/br_netfilter.c~ 2006-02-12 03:03:29.000000000 +0100
+++ linux-2.6.16-rc2-git10/net/bridge/br_netfilter.c 2006-02-12 03:03:29.000000000 +0100
@@ -805,7 +805,7 @@ static unsigned int br_nf_post_routing(u
print_error:
if (skb->dev != NULL) {
printk("[%s]", skb->dev->name);
- if (has_bridge_parent(skb->dev))
+ if (bridge_parent(skb->dev))
printk("[%s]", bridge_parent(skb->dev)->name);
}
printk(" head:%p, raw:%p, data:%p\n", skb->head, skb->mac.raw,
next reply other threads:[~2006-02-12 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 2:20 Jesper Juhl [this message]
2006-02-12 11:22 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602120320.37042.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=coreteam@netfilter.org \
--cc=jmorris@namei.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@mbsi.ca \
--cc=netfilter-devel@lists.netfilter.org \
--cc=netfilter@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome