From: Bastian Blank <bastian@waldi.eu.org>
To: Andrew Morton <akpm@osdl.org>,
Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove duplicate #includes
Date: Mon, 13 Feb 2006 11:26:56 +0100 [thread overview]
Message-ID: <20060213102656.GC26627@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20060213093959.GA10496@MAIL.13thfloor.at>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On Mon, Feb 13, 2006 at 10:39:59AM +0100, Herbert Poetzl wrote:
> diff -NurpP --minimal linux-2.6.16-rc2/drivers/char/drm/drm.h linux-2.6.16-rc2-mpf/drivers/char/drm/drm.h
> --- linux-2.6.16-rc2/drivers/char/drm/drm.h 2006-02-07 11:52:24 +0100
> +++ linux-2.6.16-rc2-mpf/drivers/char/drm/drm.h 2006-02-13 01:48:55 +0100
> @@ -51,11 +51,9 @@
> #if defined(__FreeBSD__) && defined(IN_MODULE)
> /* Prevent name collision when including sys/ioccom.h */
> #undef ioctl
> -#include <sys/ioccom.h>
> #define ioctl(a,b,c) xf86ioctl(a,b,c)
> -#else
> -#include <sys/ioccom.h>
> #endif /* __FreeBSD__ && xf86ioctl */
> +#include <sys/ioccom.h>
> #define DRM_IOCTL_NR(n) ((n) & 0xff)
> #define DRM_IOC_VOID IOC_VOID
> #define DRM_IOC_READ IOC_OUT
This one changes the behaviour. But do we want to have this non-linux
hacks in the tree?
Bastian
--
It would be illogical to assume that all conditions remain stable.
-- Spock, "The Enterprise Incident", stardate 5027.3
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2006-02-13 10:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 9:39 Herbert Poetzl
2006-02-13 10:26 ` Bastian Blank [this message]
2006-02-13 15:01 ` Herbert Poetzl
2006-02-14 15:50 ` Arthur Othieno
2006-02-15 9:48 ` Herbert Poetzl
2006-02-14 21:03 ` Jean Delvare
2006-02-14 21:21 ` Andrew Morton
2006-02-15 9:52 ` Herbert Poetzl
2006-02-15 10:12 ` Russell King
2015-07-02 21:40 [PATCH] remove duplicate includes Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213102656.GC26627@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome