From: Ingo Molnar <mingo@elte.hu>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/13] hrtimer: optimize hrtimer_get_remaining
Date: Mon, 13 Feb 2006 15:12:50 +0100 [thread overview]
Message-ID: <20060213141250.GH12923@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.61.0602130211470.23855@scrub.home>
* Roman Zippel <zippel@linux-m68k.org> wrote:
> hrtimer_get_remaining doesn't need to lock the hrtimer_base to read
> the time. Also use hrtimer_get_remaining at two other places.
nack - it's not only about ->get_time() atomicity:
> - base = lock_hrtimer_base(timer, &flags);
> - rem = ktime_sub(timer->expires, timer->base->get_time());
> - unlock_hrtimer_base(timer, &flags);
timer->expires is a 64-bit value, which might be read nonatomically on
32-bit platforms. Wherever it's safe, we already open-code this
ktime_sub() - if you find more places then please do it that way.
definitely not something for v2.6.16.
Ingo
prev parent reply other threads:[~2006-02-13 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 1:11 Roman Zippel
2006-02-13 14:12 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213141250.GH12923@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®