From: Andrew Morton <akpm@osdl.org>
To: Joshua Hudson <joshudson@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sb_bread & bforget
Date: Mon, 13 Feb 2006 20:09:05 -0800 [thread overview]
Message-ID: <20060213200905.5706dc33.akpm@osdl.org> (raw)
In-Reply-To: <bda6d13a0602131503n14650120gaa39eda9a38aefbf@mail.gmail.com>
Joshua Hudson <joshudson@gmail.com> wrote:
>
> New filesystem is using BTrees for directories. An update will touch
> multiple blocks, loaded into buffer_head structures with sb_bread.
>
> If update fails (only possible causes are read error & disk full), is it
> kosher to call bforget on all modified buffer_head structures, or
> does that have some unintended consequences?
It's probably wrong. bforget() will clear the dirty bit, so you'd lose
anything else which had been written to that buffer but not written back.
bforget() is used for truncate, where we know the data is being tosed away.
prev parent reply other threads:[~2006-02-14 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 23:03 Joshua Hudson
2006-02-14 4:09 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213200905.5706dc33.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=joshudson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®