Re: [PATCH] add asm-generic/mman.h

["Michael S. Tsirkin" <mst@mellanox.co.il>]

Quoting r. Linus Torvalds <torvalds@osdl.org>:
> Subject: Re: [PATCH] add asm-generic/mman.h
> 
> 
> 
> On Wed, 15 Feb 2006, Michael S. Tsirkin wrote:
> >
> > Other numbers look right, dont they?
> 
> Suggestion: for each macro name, do
> 
> 	grep "macroname" patch
> 
> and if you see anything that looks even half-way suspicious, check it.
> 
> Here's a pipeline from hell which shows that you broke at least 
> MADV_REMOVE (which has values 5-9 depending on architecture).
> 
> 	sed -n '/^[-+].*define[ 	]*/
> 		{ s/.*define[ 	]*\([A-Za-z_0-9]*\).*/\1/ ; p}'
> 		patch  |
> 	sort -u |
> 	while read i
> 	do
> 		echo $i:
> 		grep "^[-+].*$i" patch
> 	done |
> 	less -S

This change was intentional: MADV_REMOVE wasnt in any mainline kernels:
it was added recently, so no app should be using it, yet.

> Rule #1: use tools instead of eyeballs whenever you possibly can. Humans 
> are bad at noticing changes like this.

Right. I'll go check again.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies