From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: neilb@suse.de, linux-kernel@vger.kernel.org
Subject: Re: Possibly bug in radix_tree_delete, and fix.
Date: Wed, 15 Feb 2006 19:55:41 -0800 [thread overview]
Message-ID: <20060215195541.6a3acd67.akpm@osdl.org> (raw)
In-Reply-To: <43F3EE8F.8060000@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> Neil Brown wrote:
> > Hi Nick,
> > I believe there is a bug in radix_tree_delete introduced by:
> >
> > http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d5274261ea46f0aae93820fe36628249120d2f75
> >
> > The nature of the bug is that if a tag is set on a node that is being
> > deleted, then that tag is unconditionally cleared in the parent of the
> > node, even if the deleted node has siblings with the tag still set.
> >
> > I don't know what the large-scale consequences of this bug might be,
> > but I'm kinda hoping fixing it will fix a nasty NFS client related
> > oops we are seeing in radix_tree_tag_set ....
> >
>
> I think you're right. I was kind of suspecting I might have introduced
> a silly bug somewhere after a couple of radix tree oopses popped up.
Oh fantastic - a filesystem corrupting bug.
> Not sure why it didn't trigger Andrew's test suite, but I guess that's
> something to add.
Could you please do so? And add in the previous enhancements you made? I
was never able to sort out the patches you sent. And test Neil's later
patch (which looks OK to me)?
next prev parent reply other threads:[~2006-02-16 3:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-16 2:29 Neil Brown
2006-02-16 3:16 ` Nick Piggin
2006-02-16 3:48 ` Neil Brown
2006-02-16 3:55 ` Andrew Morton [this message]
2006-02-16 5:08 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060215195541.6a3acd67.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome