Re: [PATCH] Infineon TPM: IO-port leakage fix, WTX-bugfix

[Andrew Morton <akpm@osdl.org>]

"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> On Wed, 15 Feb 2006 14:43:47 +0100 Marcel Selhorst wrote:
> 
> > Dear all,
> > 
> > this patch fixes IO-port leakage from request_region in case of error during TPM
> > initialization, adds more pnp-verification and fixes a WTX-bug.
> > 
> > Best regards,
> > Marcel Selhorst
> > 
> > Signed-off-by: Marcel Selhorst <selhorst@crypto.rub.de>
> > ---
> > 
> > --- linux-2.6.16-rc2/drivers/char/tpm/tpm_infineon.c.old	2006-02-08
> > 11:45:09.000000000 +0100
> 
> Those 2 lines ^^^^^ should have been one line.  Email client strikes again.

Curiously patch(1) didn't care about that.

> > +
> > +err_release_region:
> > +release_region(tpm_inf.base, TPM_INF_PORT_LEN);
> > +release_region(TPM_INF_ADDR, TPM_INF_ADDR_LEN);
> > +
> > +err_last:
> > +return rc;
> >  }
> 
> The release_region() calls and return should be indented one tab stop.

Yeah, I fixed that up.

> (email client again??)

I doubt it.