From: Andrew Morton <akpm@osdl.org>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: greg@kroah.com, torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-pm@osdl.org
Subject: Re: [PATCH 1/5] [pm] Fix locking of device suspend/resume functions
Date: Fri, 17 Feb 2006 20:59:39 -0800 [thread overview]
Message-ID: <20060217205939.573e1d0c.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.50.0602171756520.30811-100000@monsoon.he.net>
Patrick Mochel <mochel@digitalimplant.org> wrote:
>
> This patch removes the unneeded down()/up() calls from
> suspend_device() and resume_device(). Those functions
> are already called under the dpm_sem, making this code
> unconditionally deadlock in SMP kernels.
I've seen no reports of such deadlocks. And I was testing swsusp on a
4-way this week?
next prev parent reply other threads:[~2006-02-18 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 2:03 Patrick Mochel
2006-02-18 4:59 ` Andrew Morton [this message]
2006-02-18 5:50 ` Patrick Mochel
2006-02-18 9:22 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060217205939.573e1d0c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=mochel@digitalimplant.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®