From: Andrew Morton <akpm@osdl.org>
To: dipankar@in.ibm.com
Cc: linux-kernel@vger.kernel.org, paulmck@us.ibm.com
Subject: Re: [PATCH 1/2] rcu batch tuning
Date: Sat, 18 Feb 2006 00:45:51 -0800 [thread overview]
Message-ID: <20060218004551.19358b6d.akpm@osdl.org> (raw)
In-Reply-To: <20060217154337.GM29846@in.ibm.com>
Dipankar Sarma <dipankar@in.ibm.com> wrote:
>
> -module_param(maxbatch, int, 0);
> +module_param(blimit, int, 0);
> +module_param(qhimark, int, 0);
> +module_param(qlowmark, int, 0);
> +#ifdef CONFIG_SMP
> +module_param(rsinterval, int, 0);
> +#endif
It's a bit unusual to add boot-time tunables via module_param, but there's
no law against it.
But you do get arrested for not adding them to
Documentation/kernel-parameters.txt. That's if you think they're permanent
(I hope they aren't). If they are, they'll probably need a more extensive
description than kernel-parameters.txt entries normally provide.
next prev parent reply other threads:[~2006-02-18 8:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 15:41 [PATCH 0/2] RCU updates Dipankar Sarma
2006-02-17 15:43 ` [PATCH 1/2] rcu batch tuning Dipankar Sarma
2006-02-17 15:46 ` [PATCH 2/2] fix file counting Dipankar Sarma
2006-02-18 9:04 ` Andrew Morton
2006-02-18 9:25 ` Dipankar Sarma
2006-02-18 9:45 ` Andrew Morton
2006-02-18 10:06 ` Dipankar Sarma
2006-02-18 10:10 ` Andrew Morton
2006-02-18 10:44 ` Dipankar Sarma
2006-02-18 12:14 ` Christoph Hellwig
2006-02-18 12:31 ` Arjan van de Ven
2006-02-20 22:36 ` [2.6 patch] make UNIX a bool Adrian Bunk
2006-02-17 20:33 ` [PATCH 1/2] rcu batch tuning Dipankar Sarma
2006-02-18 8:45 ` Andrew Morton [this message]
2006-02-18 9:15 ` Dipankar Sarma
-- strict thread matches above, loose matches on Subject: below --
2006-01-27 19:57 [patch " Oleg Nesterov
2006-01-27 23:42 ` Paul E. McKenney
2006-01-28 18:07 ` Oleg Nesterov
2006-01-30 3:30 ` Paul E. McKenney
2006-01-28 17:08 ` Dipankar Sarma
2006-01-26 18:40 [patch 0/2] RCU: fix various latency/oom issues Dipankar Sarma
2006-01-26 18:41 ` [patch 1/2] rcu batch tuning Dipankar Sarma
2006-01-26 19:33 ` Paul E. McKenney
2006-01-26 19:42 ` Dipankar Sarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060218004551.19358b6d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®