mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Luke Yang" <luke.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] Fix undefined symbols for nommu architecture
Date: Sun, 19 Feb 2006 21:42:44 -0800	[thread overview]
Message-ID: <20060219214244.03147dba.akpm@osdl.org> (raw)
In-Reply-To: <489ecd0c0602192024o2a136ddera294876ea8fd44a5@mail.gmail.com>

"Luke Yang" <luke.adi@gmail.com> wrote:
>
> Hi,
> 
>   This is a patch to add or export some undefined symbols in nommu
> architectures (mm/nommu.c).  Based on latest mm-tree. Following
> symbols are added: vmap, vunmap, randomize_va_space.
> 
> Signed-off-by: Luke Yang <luke.adi@gmail.com>
> 
> Index: git/linux-2.6/mm/nommu.c
> ===================================================================
> --- git.orig/linux-2.6/mm/nommu.c	2006-02-17 17:40:34.000000000 +0800
> +++ git/linux-2.6/mm/nommu.c	2006-02-20 12:09:32.000000000 +0800
> @@ -57,7 +57,10 @@
>  EXPORT_SYMBOL(vfree);
>  EXPORT_SYMBOL(vmalloc_to_page);
>  EXPORT_SYMBOL(vmalloc_32);
> +EXPORT_SYMBOL(vmap);
> +EXPORT_SYMBOL(vunmap);

OK.

> +int randomize_va_space = 0;

Not so sure about this one.  Does randomize_va_space actually make sense in
a nommu environment?  I guess we could load relocatable binaries into a
randomised place, but I'm not sure that this is implemented?

If no, then it would make more sense to do

	#define randomize_va_space 0

for nommu, so the relevant code gets thrown away by the compiler.

  reply	other threads:[~2006-02-20  5:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20  4:24 Luke Yang
2006-02-20  5:42 ` Andrew Morton [this message]
2006-02-20  5:57   ` Luke Yang
2006-02-20  6:06     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060219214244.03147dba.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®