From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Alessandro Zummo <azummo-vger@towertech.it>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/11] RTC subsystem, sysfs interface
Date: Sun, 19 Feb 2006 23:26:43 +0100 [thread overview]
Message-ID: <20060219232643.122b4aab@inspiron> (raw)
In-Reply-To: <200602132247.17653.dtor_core@ameritech.net>
On Mon, 13 Feb 2006 22:47:17 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > + struct rtc_time tm;
> > +
> > + if ((retval = rtc_read_time(dev, &tm)) == 0) {
>
> Retval is set unconditionally here so there is no point in initializing
> it to -ENODEV above.
> > +static int __devinit rtc_sysfs_add_device(struct class_device *class_dev,
> > + struct class_interface *class_intf)
> > +{
> > + class_device_create_file(class_dev, &class_device_attr_name);
> > + class_device_create_file(class_dev, &class_device_attr_date);
> > + class_device_create_file(class_dev, &class_device_attr_time);
> > + class_device_create_file(class_dev, &class_device_attr_since_epoch);
>
> Maybe using attribute group here will help and also allow easier error
> hanling?
done, thanks.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Turin, Italy
http://www.towertech.it
next prev parent reply other threads:[~2006-02-19 22:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 22:54 [PATCH 00/11] RTC subsystem Alessandro Zummo
2006-02-13 22:54 ` [PATCH 01/11] RTC subsystem, class Alessandro Zummo
2006-02-14 3:49 ` Dmitry Torokhov
2006-02-15 0:24 ` Alessandro Zummo
2006-02-14 9:02 ` Paul Mundt
2006-02-14 10:07 ` Alessandro Zummo
2006-02-13 22:54 ` [PATCH 02/11] RTC subsystem, ARM cleanup Alessandro Zummo
2006-02-13 22:54 ` [PATCH 03/11] RTC subsystem, I2C cleanup Alessandro Zummo
2006-02-13 22:54 ` [PATCH 04/11] RTC subsystem, sysfs interface Alessandro Zummo
2006-02-14 3:47 ` Dmitry Torokhov
2006-02-19 22:26 ` Alessandro Zummo [this message]
2006-02-13 22:54 ` [PATCH 05/11] RTC subsystem, proc interface Alessandro Zummo
2006-02-13 22:54 ` [PATCH 06/11] RTC subsystem, dev interface Alessandro Zummo
2006-02-13 22:54 ` [PATCH 07/11] RTC subsystem, X1205 driver Alessandro Zummo
2006-02-13 22:54 ` [PATCH 08/11] RTC subsystem, test device/driver Alessandro Zummo
2006-02-13 22:54 ` [PATCH 09/11] RTC subsystem, DS1672 driver Alessandro Zummo
2006-02-13 22:54 ` [PATCH 10/11] RTC subsystem, PCF8563 driver Alessandro Zummo
2006-02-13 22:54 ` [PATCH 11/11] RTC subsystem, RS5C372 driver Alessandro Zummo
2006-02-14 10:30 ` [PATCH 00/11] RTC subsystem Ben Dooks
2006-02-14 11:00 ` Alessandro Zummo
2006-02-19 23:22 Alessandro Zummo
2006-02-19 23:22 ` [PATCH 04/11] RTC subsystem, sysfs interface Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060219232643.122b4aab@inspiron \
--to=alessandro.zummo@towertech.it \
--cc=azummo-vger@towertech.it \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome