mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Nick Warne <nick@linicks.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: i386 AT keyboard LED question.
Date: Mon, 20 Feb 2006 21:24:41 +0100	[thread overview]
Message-ID: <20060220202441.GB31272@suse.cz> (raw)
In-Reply-To: <200602202003.26642.nick@linicks.net>

On Mon, Feb 20, 2006 at 08:03:26PM +0000, Nick Warne wrote:

> Hi Vojtech,
> 
> I wondered why numlock LED goes off during boot process, even though I ask 
> BIOS to turn on;
> 
> atkbd.c
> 
> /*
>  * If the get ID command failed, we check if we can at least set the LEDs on
>  * the keyboard. This should work on every keyboard out there. It also turns
>  * the LEDs off, which we want anyway.
>  */
>                 param[0] = 0;
>                 if (ps2_command(ps2dev, param, ATKBD_CMD_SETLEDS))
>                         return -1;
> 
> 
> What is the rationale *why* we want LEDS off anyway?
 
Some old notebooks forget them on, which makes the keyboard unusable -
you get '4' instead of 'u', etc.

We can't read the LED state anyway (except for going to the BIOS data
structures, which isn't reasonable from the atkbd driver), and we need
to initialize it, so off is the safer default.

Further, this has been the behavior of Linux since it was first
implemented, and thus, in my rewrite of the keyboard handling, I didn't
change it.

It's trivial to change the default lock state in init scripts / xdm
config / X config, too.

-- 
Vojtech Pavlik
Director SuSE Labs

  reply	other threads:[~2006-02-20 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20 20:03 Nick Warne
2006-02-20 20:24 ` Vojtech Pavlik [this message]
2006-02-20 20:51   ` Nick Warne
2006-02-20 20:57     ` Vojtech Pavlik
2006-02-20 21:12     ` linux-os (Dick Johnson)
2006-02-20 21:21       ` Nick Warne
2006-02-24  7:17   ` Jan Engelhardt
2006-02-24  7:27     ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060220202441.GB31272@suse.cz \
    --to=vojtech@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@linicks.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®