From: Chuck Ebbert <76306.1226@compuserve.com>
To: "Ulrich Drepper" <drepper@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Ulrich Drepper" <drepper@redhat.com>,
"Arjan van de Ven" <arjan@infradead.org>,
"Andrew Morton" <akpm@osdl.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@elte.hu>
Subject: Re: [patch 5/6] lightweight robust futexes: i386
Date: Wed, 22 Feb 2006 16:45:45 -0500 [thread overview]
Message-ID: <200602221648_MC3-1-B90A-1A02@compuserve.com> (raw)
In-Reply-To: <a36005b50602210838wa87764eof7b5d6e5a8a5ab3a@mail.gmail.com>
On Tue, 21 Feb 2006 at 08:38:04 -0800, Ulrich Drepper wrote:
> On 2/21/06, Chuck Ebbert <76306.1226@compuserve.com> wrote:
> > > + : "=a" (oldval), "=m" (*uaddr)
> > ^^^^
> > Should be "+m" because it's both read and written.
>
> No, this is why there is the "0" input parameter.
But this is arg 1, not 0. With a memory clobber it's irrelevant
anyway though.
> > > + : "memory"
> > ^^^^^^^^
> > Is this necessary? Every possible memory location that could be
> > affected has been listed in the operands if the above change is made.
>
> This makes the asm a barrier for the compiler.
A comment to that effect would be nice; IOW document the reason for it.
--
Chuck
"Equations are the Devil's sentences." --Stephen Colbert
next reply other threads:[~2006-02-22 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 21:45 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-21 15:54 Chuck Ebbert
2006-02-21 16:38 ` Ulrich Drepper
2006-02-21 8:47 Ingo Molnar
2006-02-16 9:42 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602221648_MC3-1-B90A-1A02@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=drepper@gmail.com \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®