mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Corey Minyard <minyard@acm.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Problem with NETIF_F_HIGHDMA
Date: Wed, 22 Feb 2006 11:07:11 -0800	[thread overview]
Message-ID: <20060222190711.GB27645@sorel.sous-sol.org> (raw)
In-Reply-To: <43FCB1B3.8090101@acm.org>

* Corey Minyard (minyard@acm.org) wrote:
> I was looking at a problem with a new system we are trying to get up and
> running.  It has a 32-bit only PCI network device, but is a 64-bit
> (x86_64) system.  Looking at the code for NETIF_F_HIGHDMA (which, when
> not set on a PCI network device, means that it cannot do 64-bit
> accesses) in net/core/dev.c, it seems wrong to me.

Why would NETIF_F_HIGHDMA if it's 32-bit only PCI network device?
Typically net drivers do pci_set_dma_mask, and set features accordingly.
Then pci_map_* should just work.

thanks,
-chris

  parent reply	other threads:[~2006-02-22 19:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-22 18:47 Corey Minyard
2006-02-22 18:51 ` Arjan van de Ven
2006-02-22 20:14   ` Corey Minyard
2006-02-22 20:21     ` Arjan van de Ven
2006-02-23 13:14       ` David Woodhouse
2006-02-22 19:07 ` Chris Wright [this message]
2006-02-22 20:45 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060222190711.GB27645@sorel.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®