From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch] x86_64: warn if unable to configure apic main timer
Date: Thu, 23 Feb 2006 04:17:42 -0500 [thread overview]
Message-ID: <200602230420_MC3-1-B90E-39AF@compuserve.com> (raw)
When using the APIC main timer option on x86_64, sometimes it
fails to complete its setup. Warn about this and suggest
the user try 'disable_timer_pin_1' if their system clock runs
too fast. Also, make printing of the exact result of APIC
timer calibration require 'apic=verbose'.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
--- 2.6.16-rc4-64.orig/arch/x86_64/kernel/apic.c
+++ 2.6.16-rc4-64/arch/x86_64/kernel/apic.c
@@ -738,6 +738,12 @@ static void setup_APIC_timer(unsigned in
apic_runs_main_timer++;
}
local_irq_restore(flags);
+
+ if (apic_runs_main_timer == 1) {
+ printk(KERN_WARNING "Could not configure APIC main timer.\n");
+ printk(KERN_WARNING "Try boot option 'disable_timer_pin_1'"
+ " if your system clock runs too fast.\n");
+ }
}
/*
@@ -786,7 +792,7 @@ static int __init calibrate_APIC_clock(v
result = (apic_start - apic) * 1000L * cpu_khz /
(tsc - tsc_start);
}
- printk("result %d\n", result);
+ apic_printk(APIC_VERBOSE,"APIC timer result %d\n", result);
printk(KERN_INFO "Detected %d.%03d MHz APIC timer.\n",
--
Chuck
"Equations are the Devil's sentences." --Stephen Colbert
next reply other threads:[~2006-02-23 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 9:17 Chuck Ebbert [this message]
2006-02-23 9:24 ` Andi Kleen
2006-02-23 18:07 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602230420_MC3-1-B90E-39AF@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®