mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: alokk@calsoftinc.com, manfred@colorfullife.com,
	penberg@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: Slab: Node rotor for freeing alien caches and remote per cpu pages.
Date: Thu, 23 Feb 2006 16:59:59 -0800	[thread overview]
Message-ID: <20060223165959.7b4310e4.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0602231036480.13184@schroedinger.engr.sgi.com>

Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> +void drain_node_pages(int nodeid)
>   {
>  -	struct zone *zone;
>  -	int i;
>  +	int i, z;
>   	unsigned long flags;
>   
>   	local_irq_save(flags);
>  -	for_each_zone(zone) {
>  +	for (z = 0; z < MAX_NR_ZONES; z++) {
>  +		struct zone *zone = NODE_DATA(nodeid)->node_zones + z;
>   		struct per_cpu_pageset *pset;
>   
>  -		/* Do not drain local pagesets */
>  -		if (zone->zone_pgdat->node_id == numa_node_id())
>  -			continue;
>  -
>   		pset = zone_pcp(zone, smp_processor_id());
>   		for (i = 0; i < ARRAY_SIZE(pset->pcp); i++) {

Should it be testing populated_zone() in there?

  parent reply	other threads:[~2006-02-24  1:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23 18:43 Christoph Lameter
2006-02-23 19:33 ` Andrew Morton
2006-02-23 19:41   ` Christoph Lameter
2006-02-24  1:28     ` Ravikiran G Thirumalai
2006-02-24  2:25       ` Christoph Lameter
2006-02-24  8:31         ` Ravikiran G Thirumalai
2006-02-23 21:53 ` Christoph Lameter
2006-02-24  0:59 ` Andrew Morton [this message]
2006-02-24  1:17   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060223165959.7b4310e4.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=alokk@calsoftinc.com \
    --cc=clameter@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=penberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome