Return-Path: Delivered-To: vitaly@namesys.com Received: (qmail 29339 invoked by uid 85); 12 Feb 2006 16:38:04 -0000 Received: from jeffm@locomotive.unixthugs.org by thebsh.namesys.com by uid 82 with qmail-scanner-1.15 (spamassassin: 2.43-cvs. Clear:SA:0(0.0/2.0 tests=none autolearn=no version=2.60):. Processed in 0.490437 secs); 12 Feb 2006 16:38:04 -0000 Received: from locomotive.csh.rit.edu (HELO locomotive.unixthugs.org) (postfix@129.21.60.149) by thebsh.namesys.com with SMTP; 12 Feb 2006 16:38:03 -0000 Received: by locomotive.unixthugs.org (Postfix, from userid 500) id 75B518F1C6; Sun, 12 Feb 2006 11:37:58 -0500 (EST) Date: Sun, 12 Feb 2006 11:37:58 -0500 From: Jeff Mahoney To: Andrew Morton , Linus Torvalds , Linux Kernel Mailing List , ReiserFS List Cc: Chris Mason , Hans Reiser , Vitaly Fertman Subject: [PATCH] reiserfs: disable automatic enabling of reiserfs inode attributes Message-ID: <20060212163758.GB5190@locomotive.unixthugs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: Linux 2.6.5-7.201-smp (i686) X-GPG-Fingerprint: A16F A946 6C24 81CC 99BB 85AF 2CF5 B197 2B93 0FB2 X-GPG-Key: http://www.csh.rit.edu/~jeffm/jeffm.gpg User-Agent: Mutt/1.5.6i X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on thebsh.namesys.com X-Spam-DCC: : X-Spam-Status: No, hits=0.0 required=2.0 tests=none autolearn=no version=2.60 Unfortunately, the reiserfs_attrs_cleared bit in the superblock flag can lie. File systems have been observed with the bit set, yet still contain garbage in the stat data field, causing unpredictable results. This patch backs out the enable-by-default behavior. It eliminates the changes from: d50a5cd860ce721dbeac6a4f3c6e42abcde68cd8, and ef5e5414e7a83eb9b4295bbaba5464410b11e030. fs/reiserfs/super.c | 2 -- 1 files changed, 2 deletions(-) Signed-off-by: Jeff Mahoney diff -ruNpX dontdiff linux-2.6.15/fs/reiserfs/super.c linux-2.6.15-reiserfs/fs/reiserfs/super.c --- linux-2.6.15/fs/reiserfs/super.c 2006-02-06 19:54:27.000000000 -0500 +++ linux-2.6.15-reiserfs/fs/reiserfs/super.c 2006-02-12 11:19:15.000000000 -0500 @@ -1121,8 +1121,6 @@ static void handle_attrs(struct super_bl "reiserfs: cannot support attributes until flag is set in super-block"); REISERFS_SB(s)->s_mount_opt &= ~(1 << REISERFS_ATTRS); } - } else if (le32_to_cpu(rs->s_flags) & reiserfs_attrs_cleared) { - REISERFS_SB(s)->s_mount_opt |= (1 << REISERFS_ATTRS); } } -- Jeff Mahoney SuSE Labs