mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Matthew Wilcox <matthew@wil.cx>,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: Missing piece from as659
Date: Fri, 24 Feb 2006 10:04:52 -0800	[thread overview]
Message-ID: <20060224180452.GA26821@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0602241246150.5177-100000@iolanthe.rowland.org>

On Fri, Feb 24, 2006 at 12:53:01PM -0500, Alan Stern wrote:
> On Fri, 24 Feb 2006, Matthew Wilcox wrote:
> > http://www.ussg.iu.edu/hypermail/linux/kernel/0602.2/2673.html
> > If it is a bug, of course.  It's not clear to me whether it's permissible
> > to call pci_dev_put under a spinlock or not.  That boils down to whether
> > kobject ->release methods can sleep or not.  That isn't documented in
> > Documentation/kobject.txt and I rather think it should be.
> 
> It is a bug, but it has been ignored up until recently.  Within the last 
> month or two, Greg added a might_sleep() call to put_device().  It 
> wouldn't hurt to do the same thing to kobject_put(), or maybe just 
> kobject_release().

kobject_put() will not necessarily sleep, it's only the device_put that
will, due to the locking in the driver core.

thanks,

greg k-h

      reply	other threads:[~2006-02-24 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24 16:49 Matthew Wilcox
2006-02-24 17:53 ` Alan Stern
2006-02-24 18:04   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060224180452.GA26821@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=matthew@wil.cx \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®