From: mchehab@infradead.org
To: linux-kernel@vger.kernel.org
Cc: linux-dvb-maintainer@linuxtv.org,
Hartmut Hackmann <hartmut.hackmann@t-online.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 09/13] Restore power on defaults of tda9887 after tda8290 probe
Date: Wed, 01 Mar 2006 09:05:39 -0300 [thread overview]
Message-ID: <20060301120539.PS34687000009@infradead.org> (raw)
In-Reply-To: <20060301120529.PS80375900000@infradead.org>
From: Hartmut Hackmann <hartmut.hackmann@t\-online.de>
Date: 1141009751 \-0300
The probing code for tda8290 changes the state of the tda9887 GP ports.
The patch assumes that if probing for tda8290 failed, this must be a
tda9887 and restores its power on defaults.
This should solve the module load order issue with some pinnacle cards.
Signed-off-by: Hartmut Hackmann <hartmut.hackmann@t-online.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---
drivers/media/video/saa7134/saa7134-cards.c | 4 ++--
drivers/media/video/tda8290.c | 8 +++++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
index dcffd8c..cd37880 100644
--- a/drivers/media/video/saa7134/saa7134-cards.c
+++ b/drivers/media/video/saa7134/saa7134-cards.c
@@ -2187,7 +2187,7 @@ struct saa7134_board saa7134_boards[] =
.radio_type = UNSET,
.tuner_addr = 0x61,
.radio_addr = ADDR_UNSET,
- .tda9887_conf = TDA9887_PRESENT,
+ .tda9887_conf = TDA9887_PRESENT | TDA9887_PORT1_ACTIVE,
.mpeg = SAA7134_MPEG_DVB,
.inputs = {{
.name = name_tv,
@@ -2211,7 +2211,7 @@ struct saa7134_board saa7134_boards[] =
.radio_type = UNSET,
.tuner_addr = 0x61,
.radio_addr = ADDR_UNSET,
- .tda9887_conf = TDA9887_PRESENT,
+ .tda9887_conf = TDA9887_PRESENT | TDA9887_PORT1_ACTIVE,
.mpeg = SAA7134_MPEG_DVB,
.inputs = {{
.name = name_tv,
diff --git a/drivers/media/video/tda8290.c b/drivers/media/video/tda8290.c
index 7b4fb28..a796a4e 100644
--- a/drivers/media/video/tda8290.c
+++ b/drivers/media/video/tda8290.c
@@ -580,9 +580,10 @@ int tda8290_init(struct i2c_client *c)
int tda8290_probe(struct i2c_client *c)
{
- unsigned char soft_reset[] = { 0x00, 0x00 };
- unsigned char easy_mode_b[] = { 0x01, 0x02 };
- unsigned char easy_mode_g[] = { 0x01, 0x04 };
+ unsigned char soft_reset[] = { 0x00, 0x00 };
+ unsigned char easy_mode_b[] = { 0x01, 0x02 };
+ unsigned char easy_mode_g[] = { 0x01, 0x04 };
+ unsigned char restore_9886[] = { 0x00, 0xd6, 0x30 };
unsigned char addr_dto_lsb = 0x07;
unsigned char data;
@@ -599,6 +600,7 @@ int tda8290_probe(struct i2c_client *c)
return 0;
}
}
+ i2c_master_send(c, restore_9886, 3);
return -1;
}
next prev parent reply other threads:[~2006-03-01 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 12:05 [PATCH 00/13] V4L/DVB updates mchehab
2006-03-01 12:05 ` [PATCH 04/13] Upstream sync - make 2 structs static mchehab
2006-03-01 12:05 ` [PATCH 03/13] Make a struct static mchehab
2006-03-01 12:05 ` [PATCH 01/13] Bt8xx documentation authors fix mchehab
2006-03-01 12:05 ` [PATCH 02/13] Drivers/media/dvb/frontends/mt312.c: cleanups mchehab
2006-03-01 12:05 ` [PATCH 05/13] Pinnacle PCTV 40i: add filtered Composite2 input mchehab
2006-03-01 12:05 ` [PATCH 06/13] Fixed saa7134 ALSA initialization with multiple cards mchehab
2006-03-01 12:05 ` [PATCH 07/13] Cxusb: fix lgdt3303 naming mchehab
2006-03-01 12:05 ` mchehab [this message]
2006-03-01 12:05 ` [PATCH 08/13] Fix maximum for the saturation and contrast controls mchehab
2006-03-01 12:05 ` [PATCH 10/13] Dvb: fix __init/__exit section references in av7110 driver mchehab
2006-03-01 12:05 ` [PATCH 13/13] ELSA EX-VISION 500TV: fix incorrect PCI subsystem ID mchehab
2006-03-01 12:05 ` [PATCH 11/13] Removing personal email from DVB maintainers mchehab
2006-03-01 12:05 ` [PATCH 12/13] Fix stv0297 for qam128 on tt c1500 (saa7146) mchehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301120539.PS34687000009@infradead.org \
--to=mchehab@infradead.org \
--cc=hartmut.hackmann@t-online.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®