From: Andrew Morton <akpm@osdl.org>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: torvalds@osdl.org, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [git patches] ocfs2 updates
Date: Wed, 1 Mar 2006 15:37:14 -0800 [thread overview]
Message-ID: <20060301153714.56d20f24.akpm@osdl.org> (raw)
In-Reply-To: <20060301231034.GZ20175@ca-server1.us.oracle.com>
Mark Fasheh <mark.fasheh@oracle.com> wrote:
>
> + "Extent %d at e_blkno %"MLFu64" of inode %"MLFu64" goes past ip_clusters of %u\n",
Sometime, please consider killing MLFu64 and friends.
#if (BITS_PER_LONG == 32) || defined(CONFIG_X86_64) || (defined(CONFIG_UML_X86) && defined(CONFIG_64BIT))
#define MLFi64 "lld"
#define MLFu64 "llu"
#define MLFx64 "llx"
#else
#define MLFi64 "ld"
#define MLFu64 "lu"
#define MLFx64 "lx"
#endif
You covered most cases there, but sh64 implements u64 as `unsigned long
long' (for example).
Generally we solve this problem by just using %ll and casting the args
appropriately. That does have some runtime cost on 32-bit.
u64 and s64 are the easy case - it gets stickier on things like sector_t
whose size is controlled by a CONFIG_thing on 32-bit.
next prev parent reply other threads:[~2006-03-01 23:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 23:10 Mark Fasheh
2006-03-01 23:37 ` Andrew Morton [this message]
2006-03-01 23:52 ` Mark Fasheh
-- strict thread matches above, loose matches on Subject: below --
2007-10-12 19:34 Mark Fasheh
2007-05-25 18:17 Mark Fasheh
2007-04-27 17:23 Mark Fasheh
2006-12-12 18:16 Mark Fasheh
2006-09-21 19:12 Mark Fasheh
2006-08-15 19:20 Mark Fasheh
2006-08-15 19:32 ` Greg KH
2006-06-30 0:05 Mark Fasheh
2006-03-24 23:40 Mark Fasheh
2006-03-06 22:36 Mark Fasheh
2006-02-16 21:22 Mark Fasheh
2006-02-03 23:02 Mark Fasheh
2006-01-20 1:37 Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301153714.56d20f24.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®