From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] fix potential jiffies overflow
Date: Fri, 03 Mar 2006 00:03:06 +0900 (JST) [thread overview]
Message-ID: <20060303.000306.08077845.anemo@mba.ocn.ne.jp> (raw)
I found i386 timer_resume is updating jiffies, not jiffies_64. It
looks there is a potential overflow problem. Is this a correct fix?
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
diff --git a/arch/i386/kernel/time.c b/arch/i386/kernel/time.c
index a14d594..e4ed172 100644
--- a/arch/i386/kernel/time.c
+++ b/arch/i386/kernel/time.c
@@ -413,7 +413,7 @@ static int timer_resume(struct sys_devic
xtime.tv_sec = sec;
xtime.tv_nsec = 0;
write_sequnlock_irqrestore(&xtime_lock, flags);
- jiffies += sleep_length;
+ jiffies_64 += sleep_length;
wall_jiffies += sleep_length;
if (last_timer->resume)
last_timer->resume();
next reply other threads:[~2006-03-02 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 15:03 Atsushi Nemoto [this message]
2006-03-02 16:43 ` Ram Gupta
2006-03-03 2:32 ` Atsushi Nemoto
2006-03-03 2:45 ` Andrew Morton
2006-03-03 3:31 ` Atsushi Nemoto
2006-03-03 3:48 ` Andrew Morton
2006-03-03 4:39 ` Atsushi Nemoto
2006-03-05 1:10 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060303.000306.08077845.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome