mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Bastian Blank <bastian@waldi.eu.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] s390 - fix match in ccw modalias
Date: Mon, 6 Mar 2006 08:46:39 +0100	[thread overview]
Message-ID: <20060306084639.05bd7a9b@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20060306020024.GA25620@wavehammer.waldi.eu.org>

On Mon, 6 Mar 2006 03:00:24 +0100
Bastian Blank <bastian@waldi.eu.org> wrote:

> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index be97caf..c164b23 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -246,7 +246,7 @@ static int do_ccw_entry(const char *file
>  	    id->cu_model);
>  	ADD(alias, "dt", id->match_flags&CCW_DEVICE_ID_MATCH_DEVICE_TYPE,
>  	    id->dev_type);
> -	ADD(alias, "dm", id->match_flags&CCW_DEVICE_ID_MATCH_DEVICE_TYPE,
> +	ADD(alias, "dm", id->match_flags&CCW_DEVICE_ID_MATCH_DEVICE_MODEL,
>  	    id->dev_model);
>  	return 1;
>  }

Patch makes sense to me.

> Martin: can you please push them through for 2.6.16? It breaks automatic
> loading of any dasd module.

I don't know whether Martin is operational this week, but I'd second an
inclusion into 2.6.16.

Cornelia

  reply	other threads:[~2006-03-06  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-06  2:00 Bastian Blank
2006-03-06  7:46 ` Cornelia Huck [this message]
2006-03-06 21:28   ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060306084639.05bd7a9b@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=akpm@osdl.org \
    --cc=bastian@waldi.eu.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®