From: Andrew Morton <akpm@osdl.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup
Date: Mon, 6 Mar 2006 14:37:18 -0800 [thread overview]
Message-ID: <20060306143718.50fc0d94.akpm@osdl.org> (raw)
In-Reply-To: <1141684312.17095.11.camel@dyn9047017100.beaverton.ibm.com>
Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
> Instead of passing validity of block mapping, do_mpage_readpage()
> can figure it out using buffer_mapped(). This will reduce one
> un-needed argument passing.
Is buffer_mapped() the correct flag to use? Remember that get_block() can
validly return a !buffer_mapped() bh over a file hole.
Either way, there should be a comment in there explaining the protocol,
please.
next prev parent reply other threads:[~2006-03-06 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 22:31 Badari Pulavarty
2006-03-06 22:37 ` Andrew Morton [this message]
2006-03-07 8:14 ` Badari Pulavarty
2006-03-07 16:26 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060306143718.50fc0d94.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome