From: Hans Verkuil <hverkuil@xs4all.nl>
To: v4l-dvb-maintainer@linuxtv.org
Cc: Adrian Bunk <bunk@stusta.de>,
Kyler Laird <kyler-keyword-lkml00.e701c2@lairds.com>,
mchehab@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation
Date: Wed, 8 Mar 2006 22:42:54 +0100 [thread overview]
Message-ID: <200603082242.54547.hverkuil@xs4all.nl> (raw)
In-Reply-To: <20060308211900.GM4006@stusta.de>
On Wednesday 08 March 2006 22:19, Adrian Bunk wrote:
> On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote:
> > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value
> > is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the
> > maximum value in v4l2_queryctrl is set to 255 for both of these
> > items. This means that programs (like MythTV) which set the
> > contrast and saturation to the midvalue (127) get *full* contrast
> > and saturation. (It's not pretty.)
> >
> > Setting the maximum values to 127 solves this problem.
>
> Mauro, can you comment on this issue?
It's fixed with the patch with subject '[PATCH 08/13] Fix maximum for
the saturation and contrast controls.' It was posted by Mauro to the
linux mailinglist a week ago. I hope it will be fixed in 2.6.16, but
Mauro should know more about it. It was a stupid copy-and-paste bug so
I see no reason why it shouldn't go in.
> > Please copy me on responses.
> >
> > Thank you.
> >
> > --kyler
>
> cu
> Adrian
next prev parent reply other threads:[~2006-03-08 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 5:19 Kyler Laird
2006-03-08 21:19 ` Adrian Bunk
2006-03-08 21:42 ` Hans Verkuil [this message]
2006-03-08 22:47 ` Mauro Carvalho Chehab
2006-03-08 23:46 ` Adrian Bunk
2006-03-09 0:21 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603082242.54547.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=bunk@stusta.de \
--cc=kyler-keyword-lkml00.e701c2@lairds.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®