mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Mathieu Chouquet-Stringer <mchouque@free.fr>,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: Problem on Alpha with "convert to generic irq framework"
Date: Thu, 9 Mar 2006 00:51:01 +0300	[thread overview]
Message-ID: <20060309005101.B9651@jurassic.park.msu.ru> (raw)
In-Reply-To: <20060308175652.GA28296@twiddle.net>; from rth@twiddle.net on Wed, Mar 08, 2006 at 09:56:52AM -0800

On Wed, Mar 08, 2006 at 09:56:52AM -0800, Richard Henderson wrote:
> This will need commenting if it's to go in.

Agreed. What about this?

Ivan.

--- 2.6.16-rc5/arch/alpha/kernel/irq.c	Mon Mar  6 11:57:58 2006
+++ linux/arch/alpha/kernel/irq.c	Thu Mar  9 00:38:53 2006
@@ -151,8 +151,13 @@ handle_irq(int irq, struct pt_regs * reg
 	}
 
 	irq_enter();
+	/*
+	 * __do_IRQ() must be called with IPL_MAX. Note that we do not
+	 * explicitly enable interrupts afterwards - some MILO PALcode
+	 * (namely LX164 one) seems to have severe problems with RTI
+	 * at IPL 0.
+	 */
 	local_irq_disable();
 	__do_IRQ(irq, regs);
-	local_irq_enable();
 	irq_exit();
 }

  reply	other threads:[~2006-03-08 21:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-04 11:12 Mathieu Chouquet-Stringer
2006-03-06 12:51 ` Ivan Kokshaysky
2006-03-06 13:00   ` Al Viro
2006-03-06 14:14     ` Mathieu Chouquet-Stringer
2006-03-06 13:54   ` Mathieu Chouquet-Stringer
2006-03-06 16:13     ` Ivan Kokshaysky
2006-03-06 16:31       ` Mathieu Chouquet-Stringer
2006-03-08 11:28         ` Ivan Kokshaysky
2006-03-08 12:48           ` Mathieu Chouquet-Stringer
2006-03-08 17:56           ` Richard Henderson
2006-03-08 21:51             ` Ivan Kokshaysky [this message]
2006-03-09 12:34           ` Mathieu Chouquet-Stringer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060309005101.B9651@jurassic.park.msu.ru \
    --to=ink@jurassic.park.msu.ru \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchouque@free.fr \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®