From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Andrew Morton <akpm@osdl.org>
Cc: tilman@imap.cc, linux-usb-devel@lists.sourceforge.net,
hjlipp@web.de, linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH] reduce syslog clutter (take 2)
Date: Thu, 9 Mar 2006 08:34:12 -0800 [thread overview]
Message-ID: <20060309083412.95e145ea.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060309030257.5c1e0f30.akpm@osdl.org>
On Thu, 9 Mar 2006 03:02:57 -0800 Andrew Morton wrote:
> Tilman Schmidt <tilman@imap.cc> wrote:
> >
> > The current versions of the err() / info() / warn() syslog macros
> > insert __FILE__ at the beginning of the message, which expands to
> > the complete path name of the source file within the kernel tree.
> >
> > With the following patch, when used in a module, they'll insert the
> > module name instead, which is significantly shorter and also tends to
> > be more useful to users trying to make sense of a particular message.
>
> Personally, I prefer to see filenames. Or function names. Sometimes it's
> rather unobvious how to go from module name to filename, due to a) multiple
> .o files being linked together, b) subsystems which insist on #including .c
> files in .c files (usb...) and c) the module system's cute habit of
> replacing underscores with dashes in module names.
True, just using module->name or whatever means that we would
(often?) have to do a lookup to see what source file it was in.
---
~Randy
next prev parent reply other threads:[~2006-03-09 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 22:54 Tilman Schmidt
2006-03-09 5:47 ` Randy.Dunlap
2006-03-09 10:15 ` Tilman Schmidt
2006-03-09 11:02 ` Andrew Morton
2006-03-09 16:34 ` Randy.Dunlap [this message]
2006-03-09 18:43 ` Tilman Schmidt
[not found] ` <9a8748490603091058l75aacacsfc5fdba3981fb074@mail.gmail.com>
2006-03-09 19:17 ` Tilman Schmidt
2006-03-09 21:03 ` Andrew Morton
2006-03-09 21:18 ` Pete Zaitcev
2006-03-09 22:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309083412.95e145ea.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®