mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Markus Gutschke <markus@google.com>
Cc: linux-kernel@vger.kernel.org, dkegel@google.com
Subject: Re: [PATCH 1/1] x86: Make _syscallX() macros compile in PIC mode on i386
Date: Thu, 9 Mar 2006 18:47:59 -0800	[thread overview]
Message-ID: <20060309184759.591e3551.akpm@osdl.org> (raw)
In-Reply-To: <4410BB32.1020905@google.com>

Markus Gutschke <markus@google.com> wrote:
>
> Gcc reserves %ebx when compiling position-independent-code on i386. This 
>  means, the _syscallX() macros in include/asm-i386/unistd.h will not 
>  compile. This patch is against 2.6.15.6 and adds a new set of macros 
>  which will be used in PIC mode. These macros take special care to 
>  preserve %ebx.

But we don't compile the kernel with -fpic...  We might want to, for kdump
convenience at some stage, perhaps.

If we do, it'd be better to simply replace those _syscallX functions with
versions which work in either mode, rather than having two versions.

The syscallX() macros are almost obsolete - it's preferred that code simply
include syscalls.h and call sys_foo() directly.  But there are a few
hard-to-convert places, iirc.


  reply	other threads:[~2006-03-10  2:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-09 23:33 Markus Gutschke
2006-03-10  2:47 ` Andrew Morton [this message]
2006-03-10  3:03   ` Markus Gutschke
2006-03-10  3:22     ` Andrew Morton
2006-03-10  3:36       ` dkegel
2006-03-10 23:40         ` Daniel Jacobowitz
2006-03-10 23:53           ` dkegel
2006-03-10 22:42       ` [PATCH 1/1] x86: Make _syscallX() macros compile in PIC mode on i386 (updated patch) Markus Gutschke
2006-03-10 23:02         ` dkegel
2006-03-11  0:05       ` [PATCH 1/1] x86: Make _syscallX() macros compile in PIC mode on i386 Arnd Bergmann
2006-03-10 14:37   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060309184759.591e3551.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=dkegel@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome