From: Andrew Morton <akpm@osdl.org>
To: Ian Kent <raven@themaw.net>
Cc: autofs@linux.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] autofs4 - follow_link missing funtionality
Date: Fri, 10 Mar 2006 14:50:16 -0800 [thread overview]
Message-ID: <20060310145016.39b028be.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0603102003110.3032@eagle.themaw.net>
Ian Kent <raven@themaw.net> wrote:
>
> @@ -337,10 +340,34 @@ static void *autofs4_follow_link(struct
> if (oz_mode || !lookup_type)
> goto done;
>
> + /*
> + * If the dentry contains directories then it is an
> + * autofs multi-mount with no root offset. So don't
> + * try to mount it again.
> + */
> + spin_lock(&dcache_lock);
> + if (!list_empty(&dentry->d_subdirs)) {
> + spin_unlock(&dcache_lock);
> + goto done;
> + }
> + spin_unlock(&dcache_lock);
> +
Can list_empty(&dentry->d_subdirs) become false right here, after the lock
was dropped? If so, what happens?
> status = try_to_fill_dentry(dentry, 0);
next prev parent reply other threads:[~2006-03-10 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 12:08 Ian Kent
2006-03-10 22:50 ` Andrew Morton [this message]
2006-03-11 14:10 ` Ian Kent
2006-03-26 11:51 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060310145016.39b028be.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=autofs@linux.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®