From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: tim@cyberelk.net, linux-parport@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/block/paride/pd.c: fix an off-by-one
Date: Fri, 10 Mar 2006 20:03:50 -0800 [thread overview]
Message-ID: <20060310200350.11127467.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060311034253.GI21864@stusta.de>
On Sat, 11 Mar 2006 04:42:53 +0100 Adrian Bunk wrote:
> The Coverity checker found this off-by-one error.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.16-rc5-mm3-full/drivers/block/paride/pd.c.old 2006-03-11 02:07:21.000000000 +0100
> +++ linux-2.6.16-rc5-mm3-full/drivers/block/paride/pd.c 2006-03-11 02:07:50.000000000 +0100
> @@ -275,7 +275,7 @@
> int i;
>
> printk("%s: %s: status = 0x%x =", disk->name, msg, status);
> - for (i = 0; i < 18; i++)
> + for (i = 0; i < 17; i++)
> if (status & (1 << i))
> printk(" %s", pd_errs[i]);
> printk("\n");
Please use ARRAY_SIZE(pd_errs)
and #include <linux/kernel.h>
---
~Randy
Please use an email client that implements proper (compliant) threading.
(You know who you are.)
next prev parent reply other threads:[~2006-03-11 4:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-11 3:42 Adrian Bunk
2006-03-11 4:03 ` Randy.Dunlap [this message]
2006-03-11 15:11 ` [2.6 patch] drivers/block/paride/pd.c: fix an off-by-one error Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060310200350.11127467.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®