From: Sami Farin <7atbggg02@sneakemail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: four bttv tuners in one PC crashed
Date: Sun, 12 Mar 2006 13:21:14 +0200 [thread overview]
Message-ID: <20060312112114.GA20607@m.safari.iki.fi> (raw)
In-Reply-To: <E1FI11O-0000bK-8u@be1.lrz>
On Sat, Mar 11, 2006 at 11:08:25AM +0100, Bodo Eggert wrote:
> Duncan Sands <duncan.sands@math.u-psud.fr> wrote:
>
> >> The bttv driver/chip seems to cause random memory corruption sometimes,
> >> processes will just start dying...
> >
> > There is a known buffer overflow in the bttv driver (when using
> > grabdisplay). The fix is waiting on an audit of the rest of the
> > bttv (and similar) code, since it looks like the same mistake
> > occurs in several places.
>
> Can you give me a hint on where exactly to shoot at? I'n still hoping it's
> not my VIA board giving me trouble (corrupting the first four bytes of a
> semi-random page).
check out this email to LKML
it might not be the Final Fix, but xawtv hasn't crashed on me yet
From: Duncan Sands <duncan.sands@math.u-psud.fr>
Subject: [PATCH] bttv: correct bttv_risc_packed buffer size
Date: Wed, 25 Jan 2006 11:24:27 +0100
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
boundary="Boundary-00=_cH11D22lqYSaiQl"
Message-Id: <200601251124.28392.duncan.sands@math.u-psud.fr>
--Boundary-00=_cH11D22lqYSaiQl
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
This patch fixes the strange crashes I was seeing after using
my bttv card to watch television. They were caused by a
buffer overflow in bttv_risc_packed.
The instruction buffer size calculation contains two errors:
(a) a non-zero padding value can push the start of the next bpl
section to just before a page border, leading to more scanline
splits and thus additional instructions.
(b) the first DMA region can be smaller than one page, so there can
be a scanline split even if bpl*lines is smaller than PAGE_SIZE.
For example, consider the case where offset is 0, bpl is 2, padding
is 4094, lines is smaller than 2048, the first DMA region has size 1
and all others have size PAGE_SIZE, assumed to equal 4096. Then
all bpl regions cross page borders and the number of instructions
written is 2*lines+2, rather than lines+2 (the current estimate).
With this patch the number of instructions for this example is
estimated to be 2*lines+3.
Also, the BUG_ON that was supposed to catch buffer overflows contained
a thinko causing it fire only if the buffer was overrun by a factor of
16 or more.
I didn't check whether similar mistakes exist elsewhere in the bttv
code.
Signed-off-by: Duncan Sands <baldrick@free.fr>
PS: I'm sending the patch as an attachment because for some reason my
mailer crashes if I try to insert it into the email.
--Boundary-00=_cH11D22lqYSaiQl
Content-Type: text/x-diff;
charset="us-ascii";
name="bttv"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="bttv"
Index: Linux/drivers/media/video/bttv-risc.c
===================================================================
--- Linux.orig/drivers/media/video/bttv-risc.c 2006-01-24 10:09:21.000000000 +0100
+++ Linux/drivers/media/video/bttv-risc.c 2006-01-24 10:16:06.000000000 +0100
@@ -51,8 +51,10 @@
int rc;
/* estimate risc mem: worst case is one write per page border +
- one write per scan line + sync + jump (all 2 dwords) */
- instructions = (bpl * lines) / PAGE_SIZE + lines;
+ one write per scan line + sync + jump (all 2 dwords). padding
+ can cause next bpl to start close to a page border. First DMA
+ region may be smaller than PAGE_SIZE */
+ instructions = 1 + ((bpl + padding) * lines) / PAGE_SIZE + lines;
instructions += 2;
if ((rc = btcx_riscmem_alloc(btv->c.pci,risc,instructions*8)) < 0)
return rc;
@@ -104,7 +106,7 @@
/* save pointer to jmp instruction address */
risc->jmp = rp;
- BUG_ON((risc->jmp - risc->cpu + 2) / 4 > risc->size);
+ BUG_ON(4 * (risc->jmp - risc->cpu + 2) > risc->size);
return 0;
}
--Boundary-00=_cH11D22lqYSaiQl--
--
next prev parent reply other threads:[~2006-03-12 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5NpZk-7wW-13@gated-at.bofh.it>
[not found] ` <5NJ1x-1OE-15@gated-at.bofh.it>
[not found] ` <5NPJk-3GD-3@gated-at.bofh.it>
[not found] ` <5NRBv-6ze-9@gated-at.bofh.it>
2006-03-11 10:08 ` Bodo Eggert
2006-03-12 11:21 ` Sami Farin [this message]
2006-03-06 15:34 Jiri Tyr
2006-03-06 15:56 ` Duncan Sands
2006-03-06 15:58 ` Jiri Tyr
2006-03-06 18:39 ` Jiri Tyr
2006-03-07 8:22 ` Jiri Tyr
2006-03-07 11:50 ` Jiri Tyr
2006-03-07 12:32 ` Duncan Sands
2006-03-15 8:48 ` Jiri Tyr
2006-03-15 14:21 ` Sami Farin
2006-03-15 14:30 ` Jiri Tyr
2006-03-15 15:25 ` Jiri Tyr
2006-03-15 15:41 ` Sami Farin
2006-03-07 19:08 ` Roland Scheidegger
2006-03-07 19:43 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060312112114.GA20607@m.safari.iki.fi \
--to=7atbggg02@sneakemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®