mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: linux-usb-devel@lists.sourceforge.net
Cc: "Bob Copeland" <email@bobcopeland.com>,
	"Paul Fulghum" <paulkf@microgate.com>,
	paulus@samba.org,
	"Linux Kernel list" <linux-kernel@vger.kernel.org>,
	"Greg KH" <greg@kroah.com>
Subject: Re: [linux-usb-devel] Re: 2.6.16-rc5 pppd oops on disconnects
Date: Sun, 12 Mar 2006 21:09:01 +0100	[thread overview]
Message-ID: <200603122109.02420.oliver@neukum.org> (raw)
In-Reply-To: <b6c5339f0603120958y7ebc2051q51e24835456d9fcd@mail.gmail.com>

Am Sonntag, 12. März 2006 18:58 schrieb Bob Copeland:
> On 3/12/06, Paul Fulghum <paulkf@microgate.com> wrote:
> > --- linux-2.6.16-rc5/drivers/usb/class/cdc-acm.c        2006-02-27 09:24:29.000000000 -0600
> > +++ b/drivers/usb/class/cdc-acm.c       2006-03-12 10:22:21.000000000 -0600
> > @@ -980,7 +980,7 @@ skip_normal_probe:
> >         usb_driver_claim_interface(&acm_driver, data_interface, acm);
> >
> >         usb_get_intf(control_interface);
> > -       tty_register_device(acm_tty_driver, minor, &control_interface->dev);
> > +       tty_register_device(acm_tty_driver, minor, NULL);
> >
> >         acm_table[minor] = acm;
> >         usb_set_intfdata (intf, acm);
> >
> 
> Paul,
> 
> No oops with the above patch.

I've got an itch. Is the order of interfaces in your device reversed?

	Regards
		Oliver

  reply	other threads:[~2006-03-12 20:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10 14:25 Bob Copeland
2006-03-10 17:22 ` Paul Fulghum
2006-03-10 18:48   ` Bob Copeland
2006-03-10 19:25     ` Paul Fulghum
2006-03-11 15:09       ` Bob Copeland
2006-03-11 17:56         ` Paul Fulghum
2006-03-11 20:21           ` Bob Copeland
2006-03-11 21:57             ` Paul Fulghum
2006-03-12 16:26             ` Paul Fulghum
2006-03-12 17:58               ` Bob Copeland
2006-03-12 20:09                 ` Oliver Neukum [this message]
2006-03-12 21:30                   ` [linux-usb-devel] " Bob Copeland
2006-03-13  2:21                 ` Paul Fulghum
2006-03-12  5:35 ` Greg KH
2006-03-12 16:31   ` Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603122109.02420.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=email@bobcopeland.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=paulkf@microgate.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome