From: Andrew Morton <akpm@osdl.org>
To: corbet@lwn.net (Jonathan Corbet)
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: radix tree safety
Date: Mon, 13 Mar 2006 16:14:35 -0800 [thread overview]
Message-ID: <20060313161435.30c2d865.akpm@osdl.org> (raw)
In-Reply-To: <20060314000114.24716.qmail@lwn.net>
corbet@lwn.net (Jonathan Corbet) wrote:
>
> Andrew Morton <akpm@osdl.org> wrote:
>
> > I don't really see the need - if someone goes and overindexes the data
> > structure's capacity then they have a bug and hopefully that'll turn up in
> > testing and will get fixed.
> >
> > Or am I missing something obvious which makes radix-trees particularly
> > dangerous or subtle??
>
> There's nothing in the interface documentation which says that a tag is
> an index to anything. It's an integer value which can be attached to an
> item in a radix tree. One has to look into the source to see the
> limitation built into it.
>
> If we don't want the tests, fine, but it might make sense to fix the
> interface documentation, at least, to note that "tag" is not an
> arbitrary integer value.
>
Sure, we can live with the runtime cost of a documentation fix ;)
next prev parent reply other threads:[~2006-03-14 0:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-13 22:43 Jonathan Corbet
2006-03-13 22:55 ` Nick Piggin
2006-03-13 23:50 ` Andrew Morton
2006-03-14 0:01 ` Jonathan Corbet
2006-03-14 0:14 ` Andrew Morton [this message]
2006-03-14 5:24 ` Nick Piggin
2006-03-16 17:13 ` Jonathan Corbet
2006-03-17 0:41 ` Nick Piggin
2006-03-13 23:03 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313161435.30c2d865.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome