mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject_uevent CONFIG_SYSFS=n build fix
Date: Tue, 14 Mar 2006 18:49:33 -0800	[thread overview]
Message-ID: <20060315024933.GA10742@suse.de> (raw)
In-Reply-To: <441767EB.6070908@ce.jp.nec.com>

On Tue, Mar 14, 2006 at 08:03:39PM -0500, Jun'ichi Nomura wrote:
> Hi,
> 
> Greg KH wrote:
> >>@@ -27,6 +27,8 @@
> >>#include <asm/atomic.h>
> >>
> >>#define KOBJ_NAME_LEN			20
> >>+
> >>+#ifdef CONFIG_HOTPLUG
> >>#define UEVENT_HELPER_PATH_LEN		256
> 
> >That shouldn't be needed, right?
> 
> You're right. They are not needed.
> Please disregard that part.

Looks good.  Care to resend it one more time, this time with a good
changelog description and a Signed-off-by: line?

thanks,

greg k-h

  reply	other threads:[~2006-03-15  5:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14 16:11 Jun'ichi Nomura
2006-03-14 22:01 ` Greg KH
2006-03-15  0:00   ` Jun'ichi Nomura
2006-03-15  0:09     ` Greg KH
2006-03-15  1:03       ` Jun'ichi Nomura
2006-03-15  2:49         ` Greg KH [this message]
2006-03-15 13:28           ` Jun'ichi Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060315024933.GA10742@suse.de \
    --to=gregkh@suse.de \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome