mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: linux-kernel@vger.kernel.org, perex@suse.cz
Subject: Re: Fix gus_pcm dereference before NULL
Date: Wed, 15 Mar 2006 21:24:59 -0800	[thread overview]
Message-ID: <20060315212459.74cc8b78.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060316020007.GA20734@eugeneteo.net>

On Thu, 16 Mar 2006 10:00:07 +0800 Eugene Teo wrote:

> substream is dereferenced before checking for NULL.
> 
> Coverity bug #861
> 
> Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
> 
> --- linux-2.6/sound/isa/gus/gus_pcm.c~	2006-03-15 10:05:45.000000000 +0800
> +++ linux-2.6/sound/isa/gus/gus_pcm.c	2006-03-16 09:51:43.000000000 +0800
> @@ -103,8 +103,8 @@

BTW, please use "-p" diff option so that the "@@" sections
include function or struct names etc.  I.e., be nice to patch
readers/reviewers.  :)

---
~Randy

  reply	other threads:[~2006-03-16  5:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-16  2:00 Eugene Teo
2006-03-16  5:24 ` Randy.Dunlap [this message]
2006-03-16 19:46   ` Jan Engelhardt
2006-03-16 11:00 ` Takashi Iwai
2006-03-16 11:53   ` Eugene Teo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060315212459.74cc8b78.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=eugene.teo@eugeneteo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®