From: Pavel Machek <pavel@ucw.cz>
To: Zachary Amsden <zach@vmware.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Andrew Morton <akpm@osdl.org>, Dan Hecht <dhecht@vmware.com>,
Dan Arai <arai@vmware.com>, Anne Holler <anne@vmware.com>,
Pratap Subrahmanyam <pratap@vmware.com>,
Christopher Li <chrisl@vmware.com>,
Joshua LeVasseur <jtl@ira.uka.de>, Chris Wright <chrisw@osdl.org>,
Rik Van Riel <riel@redhat.com>, Jyothy Reddy <jreddy@vmware.com>,
Jack Lo <jlo@vmware.com>, Kip Macy <kmacy@fsmware.com>,
Jan Beulich <jbeulich@novell.com>,
Ky Srinivasan <ksrinivasan@novell.com>,
Wim Coekaerts <wim.coekaerts@oracle.com>,
Leendert van Doorn <leendert@watson.ibm.com>
Subject: Re: [RFC, PATCH 9/24] i386 Vmi smp support
Date: Thu, 16 Mar 2006 00:17:55 +0100 [thread overview]
Message-ID: <20060315231755.GB1919@elf.ucw.cz> (raw)
In-Reply-To: <200603131805.k2DI5wlO005693@zach-dev.vmware.com>
On Po 13-03-06 10:05:58, Zachary Amsden wrote:
> SMP bootstrapping support. Just as in the physical platform model,
> the BSP is responsible for initializing the AP state prior to execution.
> The dependence on lots of processor state information is a design choice
> of our implementation. Conceivably, this could be a hypercall that
> awakens the same start of day state on APs as on the BSP.
>
> It is likely the AP startup and the start-of-day model will eventually
> merge into a more common interface.
>
> Signed-off-by: Zachary Amsden <zach@vmware.com>
> Signed-off-by: Daniel Arai <arai@vmware.com>
I have to admit booting virtual CPUs is easy compared to booting real
ones :-).
> +#include <asm/io.h>
> +#include <asm/highmem.h>
> +#include <asm/pgtable.h>
> +#include <vmi.h>
How it is possible that vmi.h is included without path?
> +APState ap;
Please don't hide structs like this.
> +static __init int no_ipi_broadcast(char *str)
> +{
> + get_option(&str, &no_broadcast);
> + printk ("Using %s mode\n", no_broadcast ? "No IPI Broadcast" :
> + "IPI Broadcast");
Excesive number of spaces, I' d say .
> @@ -0,0 +1,51 @@
> +/*
> + * include/asm-i386/mach-default/smpboot_hooks.h
> + *
> + * Portions Copyright 2005 VMware, Inc.
> + */
Whose are the other portions?
> +static inline void smpboot_restore_warm_reset_vector(void)
> +{
> + /*
> + * Install writable page 0 entry to set BIOS data area.
> + */
> + local_flush_tlb();
Code does not seem to match the comment.
> +/*
> + * The following vectors are part of the Linux architecture, there
> + * is no hardware IRQ pin equivalent for them, they are triggered
> + * through the ICC by us (IPIs)
> + */
> +#ifdef CONFIG_X86_SMP
> +BUILD_INTERRUPT(reschedule_interrupt,RESCHEDULE_VECTOR)
> +BUILD_INTERRUPT(invalidate_interrupt,INVALIDATE_TLB_VECTOR)
> +BUILD_INTERRUPT(call_function_interrupt,CALL_FUNCTION_VECTOR)
> +#endif
How is it different from CONFIG_SMP? Also please add " " after ",".
> +/*
> + * every pentium local APIC has two 'local interrupts', with a
"Every Pentium"
> + * soft-definable vector attached to both interrupts, one of
> + * which is a timer interrupt, the other one is error counter
> + * overflow. Linux uses the local APIC timer interrupt to get
> + * a much simpler SMP time architecture:
> + */
Pavel
--
184: br = new BinaryReader( fs );
next prev parent reply other threads:[~2006-03-15 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-13 18:05 Zachary Amsden
2006-03-15 8:17 ` Chris Wright
2006-03-15 23:17 ` Pavel Machek [this message]
2006-03-15 23:36 ` Chris Wright
2006-03-16 1:17 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315231755.GB1919@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=anne@vmware.com \
--cc=arai@vmware.com \
--cc=chrisl@vmware.com \
--cc=chrisw@osdl.org \
--cc=dhecht@vmware.com \
--cc=jbeulich@novell.com \
--cc=jlo@vmware.com \
--cc=jreddy@vmware.com \
--cc=jtl@ira.uka.de \
--cc=kmacy@fsmware.com \
--cc=ksrinivasan@novell.com \
--cc=leendert@watson.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pratap@vmware.com \
--cc=riel@redhat.com \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
--cc=wim.coekaerts@oracle.com \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®