From: Eugene Teo <eugene.teo@eugeneteo.net>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org, Valdis.Kletnieks@vt.edu
Subject: Re: Fix sequencer missing negative bound check
Date: Thu, 16 Mar 2006 11:23:18 +0800 [thread overview]
Message-ID: <20060316032318.GA21534@eugeneteo.net> (raw)
In-Reply-To: <200603160307.k2G37KLX007666@turing-police.cc.vt.edu>
<quote sender="Valdis.Kletnieks@vt.edu">
> On Thu, 16 Mar 2006 09:19:11 +0800, Eugene Teo said:
> > dev is missing a negative bound check.
> >
> > Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
[snipped]
> static void seq_sysex_message(unsigned char *event_rec)
> {
> int dev = event_rec[1];
> int i, l = 0;
> unsigned char *buf = &event_rec[2];
>
> if ((int) dev > max_synthdev)
> return;
[snipped]
> that 'int dev' came out of an 'unsigned char *' - as such, I doubt you
> can get a negative value. If anything, it should be 'unsigned int dev'.
Yes, thanks for pointing it out.
--
'int dev' came out of an 'unsigned char *' - as such, it will not get
a negative value. Thanks Valdis.
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/sound/oss/sequencer.c~ 2006-03-15 10:05:45.000000000 +0800
+++ linux-2.6/sound/oss/sequencer.c 2006-03-16 11:15:31.000000000 +0800
@@ -709,7 +709,7 @@
static void seq_sysex_message(unsigned char *event_rec)
{
- int dev = event_rec[1];
+ unsigned int dev = event_rec[1];
int i, l = 0;
unsigned char *buf = &event_rec[2];
--
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
prev parent reply other threads:[~2006-03-16 3:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 1:19 Eugene Teo
2006-03-16 3:07 ` Valdis.Kletnieks
2006-03-16 3:23 ` Eugene Teo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316032318.GA21534@eugeneteo.net \
--to=eugene.teo@eugeneteo.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®