From: Philippe De Muyter <phdm@macqel.be>
To: linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org
Subject: [PATCH] m68knommu : clear frame-pointer in start_thread
Date: Thu, 16 Mar 2006 08:59:56 +0100 [thread overview]
Message-ID: <20060316085955.C13021@mail.macqel.be> (raw)
When trying to print the calltrace of a user process on m68knommu targets
gdb follows the frame-pointer and falls on unreachable adresses, because
the frame pointer is not properly initialised by start_thread. This patch
initialises the frame pointer to NULL in start_thread.
Signed-off-by: Philippe De Muyter <phdm@macqel.be>
---
the only real change is the initialisation of a6, the rest is spacing fixes
((struct switch_stack *)(_regs))[-1].a6 = 0;
Index: linux-2.6.x/include/asm-m68knommu/processor.h
===================================================================
RCS file: /newdev6/cvsrepos/uClinux-dist/linux-2.6.x/include/asm-m68knommu/processor.h,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 processor.h
--- linux-2.6.x/include/asm-m68knommu/processor.h 2004/05/07 08:40:13 1.1.1.1
+++ linux-2.6.x/include/asm-m68knommu/processor.h 2006/03/16 07:26:52
@@ -89,14 +89,15 @@
* pass the data segment into user programs if it exists,
* it can't hurt anything as far as I can tell
*/
-#define start_thread(_regs, _pc, _usp) \
-do { \
- set_fs(USER_DS); /* reads from user space */ \
- (_regs)->pc = (_pc); \
- if (current->mm) \
- (_regs)->d5 = current->mm->start_data; \
- (_regs)->sr &= ~0x2000; \
- wrusp(_usp); \
+#define start_thread(_regs, _pc, _usp) \
+do { \
+ set_fs(USER_DS); /* reads from user space */ \
+ (_regs)->pc = (_pc); \
+ ((struct switch_stack *)(_regs))[-1].a6 = 0; \
+ if (current->mm) \
+ (_regs)->d5 = current->mm->start_data; \
+ (_regs)->sr &= ~0x2000; \
+ wrusp(_usp); \
} while(0)
/* Forward declaration, a strange C thing */
reply other threads:[~2006-03-16 7:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316085955.C13021@mail.macqel.be \
--to=phdm@macqel.be \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®