From: Andrew Morton <akpm@osdl.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
janak@us.ibm.com, viro@ftp.linux.org.uk, hch@lst.de,
mtk-manpages@gmx.net, ak@muc.de, paulus@samba.org
Subject: Re: [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed.
Date: Thu, 16 Mar 2006 14:19:27 -0800 [thread overview]
Message-ID: <20060316141927.50aabbc2.akpm@osdl.org> (raw)
In-Reply-To: <m1d5gm6ohm.fsf@ebiederm.dsl.xmission.com>
ebiederm@xmission.com (Eric W. Biederman) wrote:
>
> Linus Torvalds <torvalds@osdl.org> writes:
>
> > On Thu, 16 Mar 2006, Andrew Morton wrote:
> >>
> >> iirc there was some discussion about this and it was explicitly decided to
> >> keep the CLONE flags.
> >>
> >> Maybe Janak or Linus can comment?
> >
> > My personal opinion is that having a different set of flags is more
> > confusing and likely to result in problems later than having the same
> > ones. Regardless, I'm not touching this for 2.6.16 any more,
>
> I am actually a lot more concerned with the fact that we don't test
> for invalid bits. So we have an ABI that will change in the future,
> and that doesn't allow us to have a program that runs on old and new
> kernels.
The risk of breaking things is small - it would require someone to write a
sys_unshare-using app which a) they care about and b) has a particular bug
in it. But yes, we should check.
> I guess I can resend some version of my patch after 2.6.16 is out and
> break the ABI for the undefined bits then. Correct programs shouldn't
> care. But it sure would be nice if they could care.
>
Your single patch did two different things - there's a lesson here ;)
next prev parent reply other threads:[~2006-03-16 22:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 16:49 Eric W. Biederman
2006-03-16 17:31 ` [PATCH] unshare: Use rcu_assign_pointer when setting sighand Eric W. Biederman
2006-03-17 6:48 ` Paul E. McKenney
2006-03-17 17:44 ` Oleg Nesterov
2006-03-17 20:56 ` Andrew Morton
2006-03-18 13:12 ` Oleg Nesterov
2006-03-18 15:43 ` Janak Desai
2006-03-18 17:24 ` Oleg Nesterov
2006-03-18 17:41 ` [PATCH] for 2.6.16, disable unshare_vm() Oleg Nesterov
2006-03-18 18:10 ` Linus Torvalds
2006-03-18 18:29 ` Ulrich Drepper
2006-03-18 18:48 ` Janak Desai
2016-03-14 13:15 ` unshare(CLONE_VM) Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand Julian Smith
2016-03-14 18:35 ` Linus Torvalds
2006-03-18 13:13 ` [PATCH] implement unshare(CLONE_SIGHAND) for single-thread case Oleg Nesterov
2006-03-18 15:10 ` [PATCH] unshare: Error if passed unsupported flags Eric W. Biederman
2006-03-18 15:33 ` Janak Desai
2006-03-18 16:29 ` [PATCH] unshare: Use rcu_assign_pointer when setting sighand Janak Desai
2006-03-16 19:40 ` [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed Michael Kerrisk
2006-03-16 20:33 ` Andrew Morton
2006-03-16 20:41 ` Linus Torvalds
2006-03-16 21:58 ` Eric W. Biederman
2006-03-16 22:19 ` Andrew Morton [this message]
2006-03-16 21:36 ` Janak Desai
[not found] <1359.1142546753@www064.gmx.net>
2006-03-16 23:34 ` Michael Kerrisk
2006-03-16 23:57 ` Linus Torvalds
2006-03-17 1:11 ` Michael Kerrisk
2006-03-17 5:42 ` Linus Torvalds
2006-03-17 16:04 ` Eric W. Biederman
2006-03-17 16:49 ` Janak Desai
2006-03-17 20:27 ` Michael Kerrisk
2006-03-18 18:41 ` Eric W. Biederman
2006-03-18 19:54 ` Janak Desai
2006-03-19 13:58 ` Eric W. Biederman
2006-03-18 23:41 ` Paul Mackerras
2006-03-20 4:45 Albert Cahalan
2006-03-20 16:52 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316141927.50aabbc2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=janak@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk-manpages@gmx.net \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome