mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
	"Randy.Dunlap" <rdunlap@xenotime.net>,
	akpm@osdl.org, linux-kernel@vger.kernel.org, aia21@cantab.net,
	len.brown@intel.com
Subject: Re: [patch 1/1] consolidate TRUE and FALSE
Date: Thu, 16 Mar 2006 18:41:12 +0100	[thread overview]
Message-ID: <20060316174112.GA21003@mars.ravnborg.org> (raw)
In-Reply-To: <20060316163001.GA7222@infradead.org>

On Thu, Mar 16, 2006 at 04:30:01PM +0000, Christoph Hellwig wrote:
 
> it makes the code longer and harder to read.  there's a reason the core
> code doesn't use it, and the periphal code should do the same.
Let see:
0 is an interger zero. It is not a null pointer.
1 is an interger one
NULL is an null pointer

We agree so far?

And you say:
0 is also false
1 is also true

But others say:
0 is not false, only false is false.
1 is not true, only true is true.
Thats more readable. No magic = 1; assignments or return 1; things.

Then we will have the case where a 1 is transformed to a true, and
likewise a 0 to a false. But thats just normal type conversion.

I assume that when you are not used to see 'bool', 'true' and 'false'
then they hurt the eye, but when used to it it looks natural.

	Sam

  parent reply	other threads:[~2006-03-16 17:41 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-16 10:01 akpm
2006-03-16 10:28 ` Anton Altaparmakov
2006-03-16 10:42   ` Andrew Morton
2006-03-16 19:55     ` Nicholas Miell
2006-03-16 19:55     ` Jan Engelhardt
2006-03-16 10:36 ` Arjan van de Ven
2006-03-16 16:01 ` Christoph Hellwig
2006-03-16 16:29   ` Randy.Dunlap
2006-03-16 16:30     ` Christoph Hellwig
2006-03-16 16:36       ` Randy.Dunlap
2006-03-16 16:36         ` Christoph Hellwig
2006-03-16 16:42           ` Anton Altaparmakov
2006-03-16 16:50             ` Al Viro
     [not found]               ` <2c0942db0603160905v26011d8dx1e64967b2eb4deac@mail.gmail.com>
2006-03-16 17:11                 ` Al Viro
2006-03-16 18:50               ` Anton Altaparmakov
2006-03-16 18:53                 ` Anton Altaparmakov
2006-03-16 19:59             ` Jan Engelhardt
2006-03-16 22:35               ` Anton Altaparmakov
2006-03-16 16:42           ` Randy.Dunlap
2006-03-16 16:39       ` Anton Altaparmakov
2006-03-16 17:41       ` Sam Ravnborg [this message]
2006-03-16 18:00         ` Al Viro
2006-03-16 18:12           ` Randy.Dunlap
2006-03-16 18:49             ` Al Viro
2006-03-16 18:58               ` Randy.Dunlap
2006-03-16 18:52           ` Sam Ravnborg
2006-03-16 21:17     ` Valdis.Kletnieks
2006-03-16 21:28       ` Joshua Hudson
2006-03-16 23:53     ` David Wagner
2006-03-16 17:09   ` Xavier Bestel
2006-03-16 16:49 ` Al Viro
2006-03-16 21:26   ` Andrew Morton
2006-03-17 22:43     ` Xavier Bestel
2006-03-17 22:56       ` Andrew Morton
2006-03-18 21:57       ` Jan Engelhardt
2006-03-19 11:41         ` Xavier Bestel
2006-03-16 17:07 ` Greg KH
2006-03-16 17:13   ` Greg KH
2006-03-20 14:46 ` Richard Knutsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060316174112.GA21003@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=aia21@cantab.net \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®