From: Laurent Wandrebeck <l.wandrebeck@free.fr>
To: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: [patch 1/1] OSS msnd_pinnacle missing return check for request_region()
Date: Fri, 17 Mar 2006 11:27:55 +0100 [thread overview]
Message-ID: <200603171127.55537.l.wandrebeck@free.fr> (raw)
Hi,
in sound/oss/msnd_pinnacle.c, request_region() is called without checking the return
value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.
PS: trying with a MUA this time, since the webmail I used for previous patch
( [patch 1/1] OSS ali5455 missing return check for request_region() ) wrapped lines :(
Signed-off-by: Laurent Wandrebeck <l.wandrebeck@free.fr>
--- linux-2.6.16-rc6/sound/oss/msnd_pinnacle.c.ori 2006-03-17 10:45:46.000000000 +0100
+++ linux-2.6.16-rc6/sound/oss/msnd_pinnacle.c 2006-03-17 11:05:42.000000000 +0100
@@ -1397,7 +1397,13 @@ static int __init attach_multisound(void
printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", dev.irq);
return err;
}
- request_region(dev.io, dev.numio, dev.name);
+
+ if (!request_region(dev.io, dev.numio, dev.name)) {
+ printk(KERN_ERR LOGNAME ": Unable to reserve region %d\n",
+ dev->io);
+ free_irq(dev.irq,&dev);
+ return -EBUSY;
+ }
if ((err = dsp_full_reset()) < 0) {
release_region(dev.io, dev.numio);
reply other threads:[~2006-03-17 10:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603171127.55537.l.wandrebeck@free.fr \
--to=l.wandrebeck@free.fr \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®